This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix #1399: Make the update dialog text selectable #2990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
|
||
| // Enable text selection, since URLs aren't clickable | ||
| cursor: auto; | ||
| -webkit-user-select: text; |
There was a problem hiding this comment.
Adding these rules to the .update-text selector makes all of the text in the dialog selectable. This causes odd selection drawing if the selection includes the message at the top of the dialog. I think it would be better to add these to the .update-info selector a few lines lower.
|
Initial review complete. Thanks @TomMalbran! |
|
@gruehle Thanks and Done! |
|
Looks good! Merging. |
gruehle
added a commit
that referenced
this pull request
Mar 1, 2013
Fix #1399: Make the update dialog text selectable
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the last problem of #1399 by making the text in the update dialog selectable.