Fix #1399: Make the update dialog text selectable #2990

Merged
merged 3 commits into from Mar 1, 2013

2 participants

@TomMalbran

This fixes the last problem of #1399 by making the text in the update dialog selectable.

@gruehle gruehle was assigned Feb 28, 2013
@gruehle gruehle commented on an outdated diff Feb 28, 2013
src/styles/brackets_patterns_override.less
@@ -401,6 +401,15 @@
.update-text {
// Icon is 120px, so we need at least that much left padding/margin to avoid overlap
margin: 0 10px 0 123px;
+
+ // Enable text selection, since URLs aren't clickable
+ cursor: auto;
+ -webkit-user-select: text;
@gruehle
Adobe Systems Incorporated member
gruehle added a note Feb 28, 2013

Adding these rules to the .update-text selector makes all of the text in the dialog selectable. This causes odd selection drawing if the selection includes the message at the top of the dialog. I think it would be better to add these to the .update-info selector a few lines lower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@gruehle
Adobe Systems Incorporated member

Initial review complete. Thanks @TomMalbran!

@TomMalbran

@gruehle Thanks and Done!

@gruehle
Adobe Systems Incorporated member

Looks good! Merging.

@gruehle gruehle merged commit 72bedf8 into adobe:master Mar 1, 2013

1 check passed

Details default The Travis build passed
@TomMalbran TomMalbran deleted the TomMalbran:tom/fix-issue-1399 branch Jul 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment