Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Fix #1399: Make the update dialog text selectable #2990

Merged
merged 3 commits into from
Mar 1, 2013
Merged

Fix #1399: Make the update dialog text selectable #2990

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8227681
Make the update dialog text selectable
TomMalbran Feb 28, 2013
12a5e16
Merge remote-tracking branch 'upstream/master' into tom/fix-issue-1399
TomMalbran Feb 28, 2013
f8cd209
Make only the update info selectable
TomMalbran Feb 28, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/styles/brackets_patterns_override.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,15 @@
.update-text {
// Icon is 120px, so we need at least that much left padding/margin to avoid overlap
margin: 0 10px 0 123px;

// Enable text selection, since URLs aren't clickable
cursor: auto;
-webkit-user-select: text;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these rules to the .update-text selector makes all of the text in the dialog selectable. This causes odd selection drawing if the selection includes the message at the top of the dialog. I think it would be better to add these to the .update-info selector a few lines lower.

-khtml-user-select: text;
-moz-user-select: text;
-ms-user-select: text;
-o-user-select: text;
user-select: text;

.update-info {
max-height: 200px;
Expand Down