Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update to working phantomjs dependency #3363

Merged
merged 5 commits into from Apr 23, 2013

Conversation

Projects
None yet
2 participants
Member

jasonsanjose commented Apr 5, 2013

Pegs dev dependencies for all grunt task related deps. Explicitly pull in phantomjs and grunt-lib-phantomjs as dependencies to avoid tilde version ranges in grunt-contrib-jasmine.

Confirmed phantomjs works again on mac 10.7 with node 0.8.22 and win 7 with node 0.10.1.

@ghost ghost assigned gruehle Apr 19, 2013

Member

jasonsanjose commented Apr 19, 2013

Assigning to @gruehle.

Member

gruehle commented Apr 23, 2013

Works great on OSX 10.8, Win 7 and Win 8.

Should we do similar version pinning in brackets-shell?

@gruehle gruehle added a commit that referenced this pull request Apr 23, 2013

@gruehle gruehle Merge pull request #3363 from adobe/jasonsanjose/devDependencies
Update to working phantomjs dependency
2e34974

@gruehle gruehle merged commit 2e34974 into master Apr 23, 2013

1 check passed

default The Travis build passed
Details

@gruehle gruehle deleted the jasonsanjose/devDependencies branch Apr 23, 2013

Member

jasonsanjose commented Apr 23, 2013

Good idea. Submitted adobe/brackets-shell#233.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment