This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Update to working phantomjs dependency #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Assigning to @gruehle. |
|
Works great on OSX 10.8, Win 7 and Win 8. Should we do similar version pinning in brackets-shell? |
gruehle
added a commit
that referenced
this pull request
Apr 23, 2013
Update to working phantomjs dependency
|
Good idea. Submitted adobe/brackets-shell#233. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pegs dev dependencies for all grunt task related deps. Explicitly pull in phantomjs and grunt-lib-phantomjs as dependencies to avoid tilde version ranges in grunt-contrib-jasmine.
Confirmed phantomjs works again on mac 10.7 with node 0.8.22 and win 7 with node 0.10.1.