This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix #283 #419
Merged
Fix #283 #419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ESC key support. Remove keyup+keydown handling. Use keydown only to match native behavior.
|
Reviewing |
| /*global define: false, $: false, brackets: false */ | ||
|
|
||
| /** | ||
| * Utilities for working with Deferred, Promise, and other asynchronous processes. |
| if (buttonId) { | ||
| _dismissDialog(this, buttonId); | ||
| } else { | ||
| // Stop the event if not handled by this dialog |
There was a problem hiding this comment.
We only want to stop the event if it is not targeted for the dialog. This keydown handler is called in the capture phase, so if we stop all events here, we would not be able to have editable text inside a dialog.
|
Initial review complete |
|
Fixed Glenn's comment, but does not address #427. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #283.
Does not address #414 for tabbing between dialog controls.