Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Implement focus in dialogs #414

Closed
jasonsanjose opened this issue Mar 7, 2012 · 2 comments
Closed

Implement focus in dialogs #414

jasonsanjose opened this issue Mar 7, 2012 · 2 comments

Comments

@jasonsanjose
Copy link
Member

Our Bootstrap-based dialogs require some improvements to mimic native-like functionality. Some keyboard shortcuts can be supported (see #283), but other keyboard behaviors require focus to work properly:

  • Focus "glow" appearance is missing
  • Focus is not limited to dialog (currently pressing TAB can change focus back to controls behind the dialog)
  • Spacebar should click the focused button
  • Modal dialogs should block keyboard shortcuts from being handled by the main app (e.g. global commands in KeyBindingManager)

Twitter rejected a patch to implement focus in modals, see twbs/bootstrap#1720.

This was referenced Mar 8, 2012
@njx
Copy link
Contributor

njx commented Mar 13, 2012

Since we don't have any dialogs that need focus right now, we should move this to a user story (either combined with the first story that needs text fields in a dialog, or a separate story before that one).

We should also make sure that in the desktop version, we only allow keyboard focus on buttons (on Mac) when the appropriate system preference is set. (Currently it appears that we always allow focus on buttons on both Win and Mac.)

jasonsanjose added a commit that referenced this issue Mar 21, 2012
Dialogs disable key bindings when open. More robust focus handling should be handled by issue #414.
@jlondon
Copy link

jlondon commented Mar 22, 2012

Added to Backlog - closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants