Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Moved live highlight #4395

Merged
merged 4 commits into from Jul 17, 2013
Merged

Moved live highlight #4395

merged 4 commits into from Jul 17, 2013

Conversation

ghost
Copy link

@ghost ghost commented Jul 9, 2013

Fixes #4387

Moved live highlight in the file menu to the view menu.

From file menu to view menu.
@ghost ghost assigned njx Jul 10, 2013
@njx
Copy link
Contributor

njx commented Jul 10, 2013

Reminder to myself to update the release notes when we merge this.

@peterflynn
Copy link
Member

@njx You can tag this and/or #4387 with the "for release note" label if you want to make it more explicit :-)

@njx
Copy link
Contributor

njx commented Jul 12, 2013

@Chigurh - thanks for doing this. Talking about it further, I think we want two additional changes:

  • Change the name to "Live Preview Highlight", to make it clearer what it's related to (since it's no longer next to the LIve Preview option).
  • Since it's really different from the other options in the View menu (it affects the preview in the browser, not Brackets itself), let's move it above "Enable JSLint" and put a separator after it, so the sequence of items looks like this:
...
Word Wrap
----------------
Live Preview Highlight
----------------
Enable JSLint
...

Thanks!

@peterflynn
Copy link
Member

Further down the road, I could imagine us getting to a point where having a dedicated Live Development top-level menu makes sense...

@ghost
Copy link
Author

ghost commented Jul 12, 2013

I have changed the name but i can't figure out how to move it about Enable JSLint. I can't find "TOGGLE_JSLINT" (not sure if it's called that).

The view menu in DefaultMenus.js ends with:

menu.addMenuDivider();
menu.addMenuItem(Commands.TOGGLE_ACTIVE_LINE);
menu.addMenuItem(Commands.TOGGLE_LINE_NUMBERS);
menu.addMenuItem(Commands.TOGGLE_WORD_WRAP);
menu.addMenuItem(Commands.FILE_LIVE_HIGHLIGHT);

How are Quick view on hover and the Enable JSLint menu items added? @njx @peterflynn

@TomMalbran
Copy link
Contributor

How are Quick view on hover and the Enable JSLint menu items are added through the default extensions. So on the Default Menus you should just add a Divider and after the Live Highlight, and then on the JSLint extension extensions/JSLint change, the menu and divider creation so both are after Commands.FILE_LIVE_HIGHLIGHT and not after Commands.TOGGLE_WORD_WRAP as now.

@ghost
Copy link
Author

ghost commented Jul 12, 2013

Thanks @TomMalbran! 😄

@njx
Copy link
Contributor

njx commented Jul 17, 2013

Looks good, thanks! Merging.

njx added a commit that referenced this pull request Jul 17, 2013
@njx njx merged commit 9001e6e into adobe:master Jul 17, 2013
@ghost ghost deleted the livehighlight branch July 20, 2013 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should move "Live Highlight" to View menu
3 participants