Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Slovak language support #4856

Merged
merged 7 commits into from
Sep 6, 2013
Merged

Slovak language support #4856

merged 7 commits into from
Sep 6, 2013

Conversation

erichstark
Copy link
Contributor

No description provided.

I have translated 1/4 of all strings. The following strings I will add
later.
@zaggino
Copy link
Contributor

zaggino commented Aug 22, 2013

Translations look good to me.

@julianasuh
Copy link
Contributor

We will keep this pull request open until we receive the rest of strings.

@erichstark
Copy link
Contributor Author

Okey. I will working on it.

@erichstark erichstark closed this Aug 22, 2013
@erichstark erichstark reopened this Aug 22, 2013
@erichstark
Copy link
Contributor Author

It is done.

@zaggino
Copy link
Contributor

zaggino commented Aug 30, 2013

@erichstark quite a nice work ... but I don't know how the different plurals should be handled in the future ... you must agree the final result will sound a bit strange. Saying that, there's nothing you can do with it here.

@ghost ghost assigned jasonsanjose Aug 30, 2013
@erichstark
Copy link
Contributor Author

@zaggino Yes, you are right. But I can't do it more with that problem. I think that base of Slovak translation is okay and some of strings can be fixed in future release to fit better.

@njx
Copy link
Contributor

njx commented Aug 30, 2013

Interesting...I know there are a number of languages with varying plurals for different numbers. I wonder if there's some special kind of substitution syntax we could make up to handle this generally, and augment StringUtils.format() to handle it. I can't think of anything simple...it would have to let you enumerate various numbers or number ranges and give an associated plural.

Seems like this problem must have been solved in other localization string table systems...wonder if there's any format we could use as a reference.

@njx
Copy link
Contributor

njx commented Aug 30, 2013

(BTW, I'm not saying we have to solve that before merging this :) - if you guys are comfortable with it for now, we can merge it and file a bug to solve that problem later.)

@zaggino
Copy link
Contributor

zaggino commented Aug 30, 2013

@njx I think it's good to merge and it's a good work from @erichstark . I just felt that it was important to mention the plural problem in Slovak language :-)

@erichstark
Copy link
Contributor Author

@zaggino Thank you. :)

@njx
Copy link
Contributor

njx commented Aug 30, 2013

I filed #5007 for adding something to the string handling to make it possible to specify multiple plurals.

@@ -0,0 +1,30 @@
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erichstark can you delete this file? It's not necessary for this translation.

@jasonsanjose
Copy link
Member

@erichstark almost ready to merge. Just a few minor fixes.

@erichstark
Copy link
Contributor Author

@jasonsanjose Everything seems be ok.

jasonsanjose added a commit that referenced this pull request Sep 6, 2013
@jasonsanjose jasonsanjose merged commit 786f29c into adobe:master Sep 6, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants