This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Performance improvements for initial keystrokes in Find #5303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r two when the number of results is usually very high: - Batch tickmark creation (saves 120ms in med-size files like FindReplace) - Cut off tickmark & inline highlighting when tons of search results found (saves ~1 sec in huge files like codemirror.js)
ghost
assigned 
| * Add a tickmark to the editor's tickmark track, if it's visible | ||
| * @param curEditor {!Editor} | ||
| * @param pos {!{line:Number, ch:Number}} | ||
| */ | ||
| function addTickmark(curEditor, pos) { |
There was a problem hiding this comment.
Should this function be removed? It isn't called by anyone, and it could encourage people to write poorly performing code.
There was a problem hiding this comment.
Yep, you're right -- there's no good reason to encourage adding tickmarks one at a time
|
Initial review complete. Performance is MUCH better in large documents. I just had one question and one nit. |
|
@gruehle Changes pushed! |
|
Looks good! Merging. |
gruehle
added a commit
that referenced
this pull request
Sep 26, 2013
Performance improvements for initial keystrokes in Find
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance improvements for Find, focused on the initial keystroke or two (when the number of results is usually very high):
The timing tests I ran involved typing the letter "a" in the Find field in files of varying sizes. I think in typical files we'll save 50-150 ms, which should be quite noticeable. In huge files like codemirror.js the improvement will be much more dramatic.