Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Clean up addWidget flow #535

Merged
merged 6 commits into from
Apr 5, 2012
Merged

Clean up addWidget flow #535

merged 6 commits into from
Apr 5, 2012

Commits on Apr 4, 2012

  1. Get rid of EditorManager._addInlineWidget, an dmake it so Editor.addI… 

    …nlineWidget just takes an actual inlineWidget and stores the widget itself in the _inlineWidgets list.
    @njx
    njx committed Apr 4, 2012
    Configuration menu
    Copy the full SHA
    3b319c9 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into nj/inline-cleanup

    @njx
    njx committed Apr 4, 2012
    Configuration menu
    Copy the full SHA
    683ac5b View commit details
    Browse the repository at this point in the history

  3. Made Editor.setInlineWidgetHeight() also take a widget instead of an ID

    @njx
    njx committed Apr 4, 2012
    Configuration menu
    Copy the full SHA
    25fd303 View commit details
    Browse the repository at this point in the history

  4. Code review cleanup: changed onClosed() to close(), other minor fixes.

    @njx
    njx committed Apr 4, 2012
    1 Configuration menu
    Copy the full SHA
    1f74f8a View commit details
    Browse the repository at this point in the history

  5. Reverted close() back to onClosed() since close() already means somet… 

    …hing
    @njx
    njx committed Apr 4, 2012
    Configuration menu
    Copy the full SHA
    3d23f64 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2012

  1. Merge from master

    @njx
    njx committed Apr 5, 2012
    Configuration menu
    Copy the full SHA
    409416e View commit details
    Browse the repository at this point in the history