Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Add Greek Localization #5378

Merged
merged 19 commits into from
Jan 3, 2014
Merged

Add Greek Localization #5378

merged 19 commits into from
Jan 3, 2014

Conversation

sirodoht
Copy link
Contributor

This is the Greek localization for Brackets. Consider merging.

@marcelgerber
Copy link
Contributor

@sirodoht You should find someone to do a review of your translation.

@sirodoht
Copy link
Contributor Author

Yes, I know, but doesn't he need to be someone trustworthy?

@marcelgerber
Copy link
Contributor

We will trust you/him ;) The only thing is that he should have a GitHub account (and can speak greek).

@couzteau
Copy link
Member

couzteau commented Nov 8, 2013

@sirodoht Any update on finding a reviewer?

@sirodoht
Copy link
Contributor Author

sirodoht commented Nov 8, 2013

@couzteau Yes, I have found one. But before I want to update my translation a little bit. I haven't checked in a while on any updates on Brackets. When does it need to be ready in order to make it to the next sprint?
Also, do I need more than one reviewers?

@couzteau
Copy link
Member

couzteau commented Nov 8, 2013

@sirodoht thanks for the update. Our next sprint end Nov 15.

@couzteau
Copy link
Member

@sirodoht if you can land your changes by Thursday the timing would be better to get the changes into sprint 34.

@sirodoht
Copy link
Contributor Author

@couzteau I see. I will try to do this. Otherwise when is the next sprint release date?

@marcelgerber
Copy link
Contributor

The milestone is set to December 8, so I expect the string freeze to be around December 3 or 4.
If you can't complete the work fast enough to get it into this sprint, you should land it in the beginning of December.

@couzteau
Copy link
Member

That date is off, sprint 34 pencils down date is this thursday Nov 14.

@sirodoht
Copy link
Contributor Author

@couzteau @SAplayer and I were referring to sprint 35. I understand your confusion since 34 is the next sprint, but I meant 35.

@marcelgerber
Copy link
Contributor

@sirodoht My comment was about Sprint 35 ;)

@couzteau
Copy link
Member

@sirodoht Hey, any progress on the greek translation?

@sirodoht
Copy link
Contributor Author

@couzteau I am kind of busy these days. I hope in the next 3-4 days to have updated the translation and will be reviewed as soon as I am done.

@sirodoht
Copy link
Contributor Author

Update finished. Awaiting review.
I merged master changes and rebased. If this is not an approved technique I guess I could close this and open a new pull request.

@telis93
Copy link
Contributor

telis93 commented Nov 23, 2013

@couzteau I reviewed this translation and contributed with some minor fixes. It is a realy good work!

@couzteau
Copy link
Member

couzteau commented Jan 2, 2014

One more detail: In brackets/src/nls/root/strings.js there should be an entry
"LOCALE_EL" : "Greek",

@couzteau
Copy link
Member

couzteau commented Jan 2, 2014

@telis93 @sirodoht Sorry for the late reply. I was on vacation for the last 3 weeks.

@sirodoht
Copy link
Contributor Author

sirodoht commented Jan 3, 2014

@couzteau Done. Should I also merge master changes?

@couzteau
Copy link
Member

couzteau commented Jan 3, 2014

This is looking good. Merging Thanks @sirodoht @telis93

couzteau added a commit that referenced this pull request Jan 3, 2014
@couzteau couzteau merged commit 5a91533 into adobe:master Jan 3, 2014
@sirodoht sirodoht deleted the greek-localization branch September 5, 2014 21:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants