This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix #5741: No Live Preview Error when launching Live Preview from an image #5808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -569,7 +569,7 @@ define(function LiveDevelopment(require, exports, module) { | |||
| // After (1) the interstitial page loads, (2) then browser navigation | |||
| // to the base URL is completed, and (3) the agents finish loading | |||
| // gather related documents and finally set status to STATUS_ACTIVE. | |||
| var doc = _getCurrentDocument(); // TODO: probably wrong... | |||
| var doc = _liveDocument.doc; | |||
There was a problem hiding this comment.
Yes, this is the right thing to do. As indicated by the TODO in the old code attempting to get the current document will fail, that is return null if an image is displayed. However, liveDocument must always be set if live dev is up and running.
There was a problem hiding this comment.
It is set within this file, so that shouldn't be a problem.
couzteau
added a commit
that referenced
this pull request
Nov 4, 2013
Fix #5741: No Live Preview Error when launching Live Preview from an image
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #5741.
@julieyuan