Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Remove deprecated FileUtils.getFilenameExtension() API #5828

Merged
merged 2 commits into from
Nov 8, 2013
Merged

Remove deprecated FileUtils.getFilenameExtension() API #5828

merged 2 commits into from
Nov 8, 2013

Conversation

robvenn
Copy link
Contributor

@robvenn robvenn commented Nov 2, 2013

Removed the code for deprecated FileUtils.getFilenameExtension() as mentioned in Issue #5368:

  • deleted code for getFilenameExtension in src/file/FileUtils.js
  • edited the test for getFilenameExtension in test/spec/FileUtils-test.js and changed it to match getFileExtension

@ghost ghost assigned jasonsanjose Nov 4, 2013
@jasonsanjose
Copy link
Member

Looks good to me. @peterflynn did you still have concerns about removing the deprecated method in this sprint? I didn't see any conflicts with the filesystem API changes.

@peterflynn
Copy link
Member

Clarifying title. @rovenman in the future, please use a descriptive pull request title rather than just the bug number -- thanks!

@peterflynn
Copy link
Member

@jasonsanjose No, it's fine as far as the filesystem API changes go. The API was only deprecated in sprint 32, which isn't too long ago (definitely less time than we usually wait before removing deprecated APIs). But because we're in the special case of making larger breaking API changes this sprint anyway, maybe it's ok this time.

@peterflynn
Copy link
Member

Ok, now I'm more strongly sure it's ok. Of the three extensions I'm aware of that were using this API when it became deprecated, only one is still using it (angularui.angularjs) and it will be broken in Sprint 34 either way (unless updated) due to filesystem changes.

@jasonsanjose
Copy link
Member

Done. Let's pile 'em up now. 🎢

jasonsanjose added a commit that referenced this pull request Nov 8, 2013
Remove deprecated FileUtils.getFilenameExtension() API
@jasonsanjose jasonsanjose merged commit e318fcd into adobe:master Nov 8, 2013
@robvenn
Copy link
Contributor Author

robvenn commented Nov 11, 2013

@peterflynn Alright, didn’t know that, please excuse my ignorance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants