-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Remove dialog close button #6279 #6329
Remove dialog close button #6279 #6329
Conversation
You missed the ones in the debug extension, on both modal dialog templates. |
@TomMalbran thanks |
No problem. Notice that on the perf dialog you will need to add a close button, since without the |
@TomMalbran Would you please review? |
@kkarlesk Will do. @WebsiteDeveloper I think you removed all the "x" buttons, but there is still the issue with the perf window not having a close button. |
It looks like the perf window has a hard-coded "x" button, so just verify that it's still there after removing the global one. |
Is not really hard coded since it uses a custom modal dialog template. Should we keep that "x" button or replace it with a "close" button on the dialog footer? |
Ok. I guess we can let larz decides if he wants the "x" icon or a close button in the future when he changes that window. Is also just a debug window is is not important. We could merge it now |
Remove dialog close button #6279
Remove dialog close button #6279