Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Updates to add Croatian language #7567

Merged
merged 8 commits into from
Apr 21, 2014
Merged

Conversation

redmunds
Copy link
Contributor

Updates to add Croatian language from diomed.

This started with #7504 and #7515, so I merged those PRs here. There are also a few more changes from https://github.com/diomed/brackets.

@redmunds
Copy link
Contributor Author

@RaymondLim Could you take a look at this PR and see if you can figure out why this language isn't working? Thanks.

cc @diomed

@RaymondLim
Copy link
Contributor

@redmunds You need to add "hr": true in module.exports in src/nls/strings.js.

@@ -61,6 +61,7 @@ The following languages have been contributed by the Brackets community:
* Persian-Farsi (fa-ir)
* Finnish (fi)
* Hungarian (hu)
* Croatian (hr)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be above Hungarian (hu).

@redmunds
Copy link
Contributor Author

@RaymondLim

You need to add "hr": true in module.exports in src/nls/strings.js.

Yes, that was it. There are so many "strings.js" files that I looked at the wrong one for that step. Thanks.

@diomed This now works. This comment mentions a few more strings to review.

@redmunds
Copy link
Contributor Author

@diomed I notice a few more strings in the strings.js file need to be translated:

    "FILE_FILTER_DIALOG"                : "Edit Filter",
    "FILE_FILTER_INSTRUCTIONS"          : "Exclude files and folders matching any of the following strings / substrings or <a href='{0}' title='{0}'>globs</a>. Enter each string on a new line.",

Also, the last 2 words of this long one:

    "BEZIER_EDITOR_INFO"                        : "<kbd>↑</kbd><kbd>↓</kbd><kbd>←</kbd><kbd>→</kbd> Pomakni odabranu point*<br><kbd class='text'>Shift</kbd> Pomakni za 10 jedinica<br><kbd class='text'>Tab</kbd> Switch points",

@TomMalbran
Copy link
Contributor

@redmunds You also need to add "hr": true in module.exports in src/nls/urls.js for the urls to work.

@redmunds
Copy link
Contributor Author

@TomMalbran

You also need to add "hr": true in module.exports in src/nls/urls.js

Done. Thanks.

cc @diomed

@diomed
Copy link
Contributor

diomed commented Apr 20, 2014

I've updated strings.js with some of requested strings, and updated some of existing strings with new name, because I did not properly translate previous one.

However, I'm unsure of this:

  1. "ERROR_TIMINGQUICKEDIT_INVALIDSYNTAX" : "Quick CSS Timing Function editing",

Timing Function - what is that, what does it do - can someone explain it to me, so I could translate it properly?.

@redmunds
Copy link
Contributor Author

Paste this css rule in a style sheet:

.test {
    transition-timing-function: cubic-bezier(.62, 0, 1, .98);
    transition-timing-function: steps(6, start);
}

Put cursor in each line and press Ctrl/Cmd-E to invoke the timing function editors for each of those functions.

@diomed
Copy link
Contributor

diomed commented Apr 21, 2014

I've checked my CSS book and translated as it says.
Now, is there anything else I should translate ,or is that it?

@redmunds
Copy link
Contributor Author

Looks good. Merging.

redmunds added a commit that referenced this pull request Apr 21, 2014
@redmunds redmunds merged commit c439863 into master Apr 21, 2014
This was referenced Apr 22, 2014
@diomed
Copy link
Contributor

diomed commented Apr 30, 2014

Hi! I'm not sure do you still receive my updated or not, so I'm just writing here to let you know that I've changed a few strings; 1 was untranslated, and other ones were not grammatically correct, so I've fixed them too.

@redmunds
Copy link
Contributor Author

@diomed I think that I merged all of your strings into the brackets master branch on April 21st in this commit -- take a look and see what's there. I have not merged any of your changes since then. You need to submit a pull request each time you have additional changes.

Note that I researched using transifex.com for Brackets, but they currently do not support the requirejs i18n system that we use. Let them know to add support for it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants