Support package.json i18n key and show a hint in case the extension is t... #7995

marcelgerber · 2014-05-31T09:30:21Z

...ranslated into the users language

Implements #6835.

njx · 2014-06-02T17:21:05Z

Cool feature! Thanks for working on this. To @dangoor

dangoor · 2014-06-06T15:13:20Z

@SAplayer I will get to this next week.

dangoor · 2014-06-10T14:52:17Z

src/extensibility/ExtensionManagerView.js

+
+            // TODO: Unify with the exact same function in extensions/default/DebugCommands/main.js
+            // New module?
+            var getLocalizedLabel = function (locale) {


Yes, this should be pulled out somewhere else. Maybe StringUtils?

Unfortunately, we can't access the Strings from StringUtils, they are loaded later.

Ahh, yeah, I see that does get a bit tangled. It seems a shame to create a new "i18nUtils.js" for this one function, but I can imagine us having more functions over time and I don't like the idea of duplicating this function, small though it is.

What do you think about just having a new file?

Sounds like a great idea.
But I don't know about the name right now, so I'll just start with "LocalizationUtils" for now.

dangoor · 2014-06-10T15:12:29Z

Thanks for the PR, @SAplayer!

Two top-level comments:

this needs unit tests. We've got a pretty extensive set of tests for this code, so it hopefully won't be too hard to add.
Do you think we should display anything in the event that a package has translations but hasn't been translated into the user's language? Perhaps to encourage them to help with a translation?

…s translated into the users language

marcelgerber · 2014-06-16T23:10:20Z

@dangoor

LocalizationUtils (What about the name?)
Unit tests (Are two enough? Shall we test more scenarios? Shall we test registry extensions as well?)
Message for translated extensions not translated into user's language

dangoor · 2014-06-27T14:29:50Z

@SAplayer Sorry I didn't get to this this week. I will try to land this after getting back on July 8th.

TomMalbran · 2014-06-27T17:47:11Z

src/extensibility/ExtensionManagerView.js

+                        // List users language first
+                        var isUserLang,
+                            locales = [lang1.locale, lang2.locale];
+                        isUserLang = locales.indexOf(lang);


Small nit. This can be done:

var locales = [lang1.locale, lang2.locale], isUserLang = locales.indexOf(lang);

And isUserLang is actually the index in the index in the array. so it needs a better name like userLangIndex or shorter if possible.

Conflicts: src/utils/StringUtils.js

marcelgerber · 2014-07-04T20:15:24Z

@dangoor Pushed.

marcelgerber · 2014-07-04T20:17:16Z

src/nls/root/strings.js

@@ -472,6 +472,9 @@ define({
    "EXTENSION_MORE_INFO"                  : "More info...",
    "EXTENSION_ERROR"                      : "Extension error",
    "EXTENSION_KEYWORDS"                   : "Keywords",
+    "EXTENSION_TRANSLATED_USER_LANG"       : "Translated into your language",
+    "EXTENSION_TRANSLATED_GENERAL"         : "Translated into some languages",
+    "EXTENSION_TRANSLATED_LANGS"           : "This extension has been translated into these languages: {0}",


We definitely need some wordsmithing here and maybe even another EXTENSION_TRANSLATED_LANGS string for the "not translated into user's lang" case (like Contribute a translation to make the extension even more awesome)

Hmm... I think that the way you have it here makes a good compromise between being concise and presenting what the user needs to know. I'd be inclined to go with this as you have it for the time being.

What about Translated into {1} languages and respectively Translated into {1} languages, including yours?
The problem about that is that we have to provide singular and plural translations...

Yeah, I agree that's nicer wording. Is it worth having to define two strings for? It's not even clear to me how many extensions will get translations.

Well, we usually use two strings everytime there's singular/plural, so I guess in this case it's the same.
And many (common) extensions already got translated, like Brackets Git, Theseus, Brackets Code Folding, HTML Skeleton, Brackets Todo, ... (OK, not too many, but those are very common)

If an extension is translated into another language, that means that is is in English and in another language. So there are always at least 2 languages when it is translated. Which means that we don't really need a singular form.

@TomMalbran Yes, it should be, but it's still possible that an extension author uses an array like ["en"] or ["de"].
But I'm ok with having only a plural form, even though it will sound odd in such cases.

dangoor · 2014-07-08T13:36:05Z

One minor nit: I'm not sure about the added font weight on the string about the translation. It may be better if it's just the same as keywords. @larz0 what do you think? (see screenshot below for the "translated into some languages" string)

marcelgerber · 2014-07-08T14:38:44Z

@dangoor I just wanted an easy way to differ keywords and the translation hint. If you know any better method, feel free to share it.

larz0 · 2014-07-08T16:39:38Z

@dangoor @SAplayer we can make the styling the same as keywords because keywords will be hidden once we merge #8282.

marcelgerber · 2014-07-08T18:07:33Z

@larz0 @dangoor Changed.

marcelgerber · 2014-07-09T15:03:05Z

@dangoor Changed once again.

dangoor · 2014-07-21T15:59:37Z

@SAplayer Looks good, merging.

Would you be able to update the package format documentation?

Thanks for the work on this!

Support package.json i18n key and show a hint in case the extension is t...

marcelgerber · 2014-07-21T17:40:54Z

@dangoor Updated it: https://github.com/adobe/brackets/wiki/Extension-package-format#details

dangoor · 2014-07-21T17:54:12Z

Thanks @SAplayer!

njx assigned dangoor Jun 2, 2014

njx added the medium priority label Jun 2, 2014

dangoor reviewed Jun 10, 2014
View reviewed changes

dangoor added the PR Triage Complete label Jun 11, 2014

Marcel Gerber added 3 commits June 16, 2014 23:02

Support package.json i18n key and show a hint in case the extension i…

da526e8

…s translated into the users language

Code review changes, LocalizationUtils

1b09b6d

Unit tests

f7144a8

TomMalbran reviewed Jun 27, 2014
View reviewed changes

Marcel Gerber added 2 commits July 4, 2014 21:29

Merge remote-tracking branch 'upstream/master' into i18n-extman

3d87d68

Conflicts: src/utils/StringUtils.js

Show a message even if the ext wasn't translated into user's lang

e3beb35

marcelgerber reviewed Jul 4, 2014
View reviewed changes

dangoor added the Review label Jul 8, 2014

Stylesheet change

adaeb88

Marcel Gerber added 2 commits July 9, 2014 16:56

Merge remote-tracking branch 'upstream/master' into i18n-extman

4c6af3a

Changed string

f23dbfe

dangoor added a commit that referenced this pull request Jul 21, 2014

Merge pull request #7995 from SAPlayer/i18n-extman

0696a23

Support package.json i18n key and show a hint in case the extension is t...

dangoor merged commit 0696a23 into adobe:master Jul 21, 2014

marcelgerber deleted the i18n-extman branch July 21, 2014 17:40

le717 mentioned this pull request Jul 21, 2014

Truncate extension descriptions #8282

Merged

3 tasks

marcelgerber mentioned this pull request Jul 25, 2014

Add i18n key to package.json brackets-userland/brackets-git#652

Merged

raducotescu mentioned this pull request Aug 13, 2014

Add i18n information in package.json adobe/aem-brackets-extension#8

Closed

core-ai-bot mentioned this pull request Aug 30, 2021

[CLOSED] Support package.json i18n key and show a hint in case the extension is t... brackets-archive/bracketsIssues#7161

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support package.json i18n key and show a hint in case the extension is t... #7995

Support package.json i18n key and show a hint in case the extension is t... #7995

marcelgerber commented May 31, 2014

njx commented Jun 2, 2014

dangoor commented Jun 6, 2014

dangoor Jun 10, 2014

marcelgerber Jun 14, 2014

dangoor Jun 16, 2014

marcelgerber Jun 16, 2014

dangoor commented Jun 10, 2014

marcelgerber commented Jun 16, 2014

dangoor commented Jun 27, 2014

TomMalbran Jun 27, 2014

marcelgerber commented Jul 4, 2014

marcelgerber Jul 4, 2014

dangoor Jul 8, 2014

marcelgerber Jul 8, 2014

dangoor Jul 8, 2014

marcelgerber Jul 8, 2014

TomMalbran Jul 8, 2014

marcelgerber Jul 9, 2014

dangoor commented Jul 8, 2014

marcelgerber commented Jul 8, 2014

larz0 commented Jul 8, 2014

marcelgerber commented Jul 8, 2014

marcelgerber commented Jul 9, 2014

dangoor commented Jul 21, 2014

marcelgerber commented Jul 21, 2014

dangoor commented Jul 21, 2014

Support package.json i18n key and show a hint in case the extension is t... #7995

Support package.json i18n key and show a hint in case the extension is t... #7995

Conversation

marcelgerber commented May 31, 2014

njx commented Jun 2, 2014

dangoor commented Jun 6, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dangoor commented Jun 10, 2014

marcelgerber commented Jun 16, 2014

dangoor commented Jun 27, 2014

Choose a reason for hiding this comment

marcelgerber commented Jul 4, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dangoor commented Jul 8, 2014

marcelgerber commented Jul 8, 2014

larz0 commented Jul 8, 2014

marcelgerber commented Jul 8, 2014

marcelgerber commented Jul 9, 2014

dangoor commented Jul 21, 2014

marcelgerber commented Jul 21, 2014

dangoor commented Jul 21, 2014