New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick Docs: Ignore vendor prefixes if needed #8739

Merged
merged 5 commits into from Sep 9, 2014

Conversation

Projects
None yet
4 participants
@MarcelGerber
Contributor

MarcelGerber commented Aug 12, 2014

For #8737.

@le717

This comment has been minimized.

Show comment
Hide comment
@le717

le717 Aug 17, 2014

Contributor

👍 This is a very good idea.

Contributor

le717 commented Aug 17, 2014

👍 This is a very good idea.

@RaymondLim

This comment has been minimized.

Show comment
Hide comment
@RaymondLim

RaymondLim Aug 18, 2014

Contributor

Triage complete.

Contributor

RaymondLim commented Aug 18, 2014

Triage complete.

@redmunds redmunds self-assigned this Aug 26, 2014

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Sep 8, 2014

Contributor

Done with initial review. RegExp needs to be more strict.

Contributor

redmunds commented Sep 8, 2014

Done with initial review. RegExp needs to be more strict.

@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Sep 9, 2014

Contributor

@redmunds Changed the RegExp.

Contributor

MarcelGerber commented Sep 9, 2014

@redmunds Changed the RegExp.

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Sep 9, 2014

Contributor

Looks good.

Sorry, for not mentioning it on the first pass, but please add unit tests for

  • valid vendor prefixes
  • invalid property that starts with a - but is not a vendor prefix
Contributor

redmunds commented Sep 9, 2014

Looks good.

Sorry, for not mentioning it on the first pass, but please add unit tests for

  • valid vendor prefixes
  • invalid property that starts with a - but is not a vendor prefix
@MarcelGerber

This comment has been minimized.

Show comment
Hide comment
@MarcelGerber

MarcelGerber Sep 9, 2014

Contributor

@redmunds Added unit tests and fixed a case where you couldn't open an Inline Editor when your cursor was on the very beginning (before the first hyphen).

Contributor

MarcelGerber commented Sep 9, 2014

@redmunds Added unit tests and fixed a case where you couldn't open an Inline Editor when your cursor was on the very beginning (before the first hyphen).

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Sep 9, 2014

Contributor

Thanks. Merging.

Contributor

redmunds commented Sep 9, 2014

Thanks. Merging.

redmunds added a commit that referenced this pull request Sep 9, 2014

Merge pull request #8739 from MarcelGerber/wp-docs-vendor-prefixes
Quick Docs: Ignore vendor prefixes if needed

@redmunds redmunds merged commit 90c912e into adobe:master Sep 9, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@MarcelGerber MarcelGerber deleted the MarcelGerber:wp-docs-vendor-prefixes branch Sep 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment