This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Quick Docs: Ignore vendor prefixes if needed #8739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 This is a very good idea. |
|
Triage complete. |
| @@ -110,6 +110,10 @@ define(function (require, exports, module) { | |||
| .done(function (cssDocs) { | |||
| // Construct inline widget (if we have docs for this property) | |||
| var cssPropDetails = cssDocs.PROPERTIES["css/properties/" + cssPropName]; | |||
| if (!cssPropDetails) { | |||
| cssPropName = cssPropName.replace(/^-\w+-/, ""); // remove possible vendor prefixes | |||
There was a problem hiding this comment.
This RegExp could lead to false positives if there's a typo in a css property name. For example, if property is mistyped as -border-width, then user will see info for width. RegExp should explicitly list most popular vendor prefixes such as: /^-(webkit|moz|ms|o)-/.
|
Done with initial review. RegExp needs to be more strict. |
|
@redmunds Changed the RegExp. |
|
Looks good. Sorry, for not mentioning it on the first pass, but please add unit tests for
|
|
@redmunds Added unit tests and fixed a case where you couldn't open an Inline Editor when your cursor was on the very beginning (before the first hyphen). |
|
Thanks. Merging. |
redmunds
added a commit
that referenced
this pull request
Sep 9, 2014
Quick Docs: Ignore vendor prefixes if needed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8737.