New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve the issue with the default scope being overriden #9047

Merged
merged 2 commits into from Sep 15, 2014

Conversation

Projects
None yet
2 participants
@busykai
Contributor

busykai commented Sep 10, 2014

The default's scope load() was executing after the scope was already filled out with preferences.

Also, re-work adding to scope using explicit shadow entry state tracking (instead of promises).

cc: @redmunds

@redmunds redmunds self-assigned this Sep 10, 2014

} else {
return Promise.resolve();
}
})

This comment has been minimized.

@redmunds

redmunds Sep 15, 2014

Contributor

JSLlint is complaining about this block being indented.

@redmunds

redmunds Sep 15, 2014

Contributor

JSLlint is complaining about this block being indented.

@@ -216,7 +216,6 @@ define(function (require, exports, module) {
* Setup Brackets
*/
function _onReady() {
window.alert("brackets.js _onReady()");

This comment has been minimized.

@redmunds

redmunds Sep 15, 2014

Contributor

Ooops! :)

@redmunds

redmunds Sep 15, 2014

Contributor

Ooops! :)

@redmunds

This comment has been minimized.

Show comment
Hide comment
@redmunds

redmunds Sep 15, 2014

Contributor

Thanks. I'm going to merge and fix the JSLint errors. I'm also seeing a weird problem with Recent Project dropdown, but I suspect this branch just needs to be merged with master.

Contributor

redmunds commented Sep 15, 2014

Thanks. I'm going to merge and fix the JSLint errors. I'm also seeing a weird problem with Recent Project dropdown, but I suspect this branch just needs to be merged with master.

redmunds added a commit that referenced this pull request Sep 15, 2014

Merge pull request #9047 from adobe/kai/promises-upgrade
Resolve the issue with the default scope being overriden

@redmunds redmunds merged commit 4aa4f2a into promises-upgrade Sep 15, 2014

@redmunds redmunds deleted the kai/promises-upgrade branch Sep 15, 2014

@busykai

This comment has been minimized.

Show comment
Hide comment
@busykai

busykai Sep 16, 2014

Contributor

Yeah, I need to get to multiple linters ASAP... Switching between linters is something I always forget to do. Sorry!

Contributor

busykai commented Sep 16, 2014

Yeah, I need to get to multiple linters ASAP... Switching between linters is something I always forget to do. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment