This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Resolve the issue with the default scope being overriden #9047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else { | ||
| return Promise.resolve(); | ||
| } | ||
| }) |
There was a problem hiding this comment.
JSLlint is complaining about this block being indented.
|
Thanks. I'm going to merge and fix the JSLint errors. I'm also seeing a weird problem with Recent Project dropdown, but I suspect this branch just needs to be merged with master. |
redmunds
added a commit
that referenced
this pull request
Sep 15, 2014
Resolve the issue with the default scope being overriden
|
Yeah, I need to get to multiple linters ASAP... Switching between linters is something I always forget to do. Sorry! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default's scope load() was executing after the scope was already filled out with preferences.
Also, re-work adding to scope using explicit shadow entry state tracking (instead of promises).
cc: @redmunds