New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish translation update #9078

Merged
merged 5 commits into from Sep 13, 2014

Conversation

Projects
None yet
3 participants
@jamesxv7
Contributor

jamesxv7 commented Sep 12, 2014

Minor changes were made to the following sections in order to express the sentence or phrase more fluently for the reader in the native language.

jamesxv7 added some commits Sep 12, 2014

Update strings.js
Minor changes were made to the following sections in order to express the sentence or phrase more fluently for the reader in the native language.
- "ERROR_PREFS_CORRUPT"
- "ERROR_IN_BROWSER" 
- "ERROR_MAX_FILES"
- "ERROR_LAUNCHING_BROWSER_TITLE"
- "ERROR_FETCHING_UPDATE_INFO_MSG"
- "ERROR_QUICK_EDIT_PROVIDER_NOT_FOUND"
- "ERROR_QUICK_DOCS_PROVIDER_NOT_FOUND"
- "ABOUT_TEXT_WEB_PLATFORM_DOCS"
- "CANNOT_WRITE_TEMP"
Update strings.js
Minor changes were made to the following sections in order to express the sentence or phrase more fluently for the reader in the native language.
Show outdated Hide outdated src/nls/es/strings.js
// FileIndexManager error string
"ERROR_MAX_FILES_TITLE" : "Error indexando archivos",
"ERROR_MAX_FILES" : "Este proyecto contiene más de 30.000 archivos. Funciones que operan sobre múltiples archivos pueden estar deshabilitadas o funcionar igual que si el proyecto estuviese vacío. <a href='https://github.com/adobe/brackets/wiki/Large-Projects'>Leer más acerca de cómo trabajar con grandes proyectos</a>.",
"ERROR_MAX_FILES" : "Este proyecto contiene más de 30.000 archivos. Funciones que operan sobre múltiples archivos pueden estar deshabilitadas o funcionar igual que si el proyecto estuviese vacío. <a href='https://github.com/adobe/brackets/wiki/Large-Projects'>Leer más acerca de cómo trabajar con proyectos grandes</a>.",

This comment has been minimized.

@TomMalbran

TomMalbran Sep 12, 2014

Contributor

Nit: There are 2 spaces between con and proyectos.

@TomMalbran

TomMalbran Sep 12, 2014

Contributor

Nit: There are 2 spaces between con and proyectos.

@@ -408,7 +408,7 @@ define({
"ABOUT_TEXT_LINE4" : "Puedes encontrar la documentación y código fuente en <a href='https://github.com/adobe/brackets/'>https://github.com/adobe/brackets/</a>",
"ABOUT_TEXT_LINE5" : "Hecho con \u2764 y JavaScript por:",
"ABOUT_TEXT_LINE6" : "Mucha gente (pero ahora mismo estamos teniendo problemas para cargar esos datos).",
"ABOUT_TEXT_WEB_PLATFORM_DOCS" : "El contenido de Web Platform Docs y el logo de Web Platform están disponibles bajo una Licencia de Reconocimiento de Creative Commons, <a href='{WEB_PLATFORM_DOCS_LICENSE}'>CC-BY 3.0 Unported</a>.",
"ABOUT_TEXT_WEB_PLATFORM_DOCS" : "El contenido de Web Platform Docs y el logo de Web Platform están disponibles bajo Licencia de Reconocimiento de Creative Commons, <a href='{WEB_PLATFORM_DOCS_LICENSE}'>CC-BY 3.0 Unported</a>.",

This comment has been minimized.

@TomMalbran

TomMalbran Sep 12, 2014

Contributor

I think that una was used right here.

@TomMalbran

TomMalbran Sep 12, 2014

Contributor

I think that una was used right here.

This comment has been minimized.

@jamesxv7

jamesxv7 Sep 12, 2014

Contributor

Yes, I agree, but having it does not add value unless you wish to indicate that it is a single license.

@jamesxv7

jamesxv7 Sep 12, 2014

Contributor

Yes, I agree, but having it does not add value unless you wish to indicate that it is a single license.

Show outdated Hide outdated src/nls/es/strings.js
@@ -469,7 +469,7 @@ define({
"DOWNLOAD_ID_IN_USE" : "Error interno: el ID de descarga ya está siendo utilizado.",
"NO_SERVER_RESPONSE" : "No se puede conectar con el servidor.",
"BAD_HTTP_STATUS" : "Archivo no encontrado en el servidor (HTTP {0}).",
"CANNOT_WRITE_TEMP" : "No se pudo guardar la descarga en un archivo temporal.",
"CANNOT_WRITE_TEMP" : "No se pudo guardar la descarga en un archivo temporero.",

This comment has been minimized.

@TomMalbran

TomMalbran Sep 12, 2014

Contributor

temporal is the right term here.

@TomMalbran

TomMalbran Sep 12, 2014

Contributor

temporal is the right term here.

@TomMalbran

This comment has been minimized.

Show comment
Hide comment
@TomMalbran

TomMalbran Sep 12, 2014

Contributor

Thanks for the fixes. You need to sign the Contribution Agreement before we can merge it.

Contributor

TomMalbran commented Sep 12, 2014

Thanks for the fixes. You need to sign the Contribution Agreement before we can merge it.

jamesxv7 added some commits Sep 12, 2014

Update strings.js
Fixed 2 spaces between con and proyectos as per TomMalbran revision.
@jamesxv7

This comment has been minimized.

Show comment
Hide comment
@jamesxv7

jamesxv7 Sep 12, 2014

Contributor

Contribution Agreement already signed. Do you agree with the explanation of line 411?

Contributor

jamesxv7 commented Sep 12, 2014

Contribution Agreement already signed. Do you agree with the explanation of line 411?

@peterflynn peterflynn changed the title from Patch 1 to Spanish translation update Sep 13, 2014

@peterflynn

This comment has been minimized.

Show comment
Hide comment
@peterflynn

peterflynn Sep 13, 2014

Member

Fixing name. @jamesxv7 for future reference, you can give your pull requests a more descriptive name on the "New Pull Request" screen, before you click "Send Pull Request." (The same screen where you enter the longer description shown in small text at the top of this page: "Minor changes were made to the following sections...")

Member

peterflynn commented Sep 13, 2014

Fixing name. @jamesxv7 for future reference, you can give your pull requests a more descriptive name on the "New Pull Request" screen, before you click "Send Pull Request." (The same screen where you enter the longer description shown in small text at the top of this page: "Minor changes were made to the following sections...")

Show outdated Hide outdated src/nls/es/strings.js
@@ -593,4 +593,4 @@ define({
"DOCS_MORE_LINK" : "Más"
});
/* Last translated for 8712385a6bf12277e6d0788d408e630a40c95a14 */
/* Last translated for 6a04a7aa53769b1e7e0a0989f95bcafb92b5a11e */

This comment has been minimized.

@TomMalbran

TomMalbran Sep 13, 2014

Contributor

Can you revert this line? The sha is grabbed from here: https://github.com/adobe/brackets/commits/master/src/nls/root/strings.js when the file is changed to have the same strings as root/strings.js

@TomMalbran

TomMalbran Sep 13, 2014

Contributor

Can you revert this line? The sha is grabbed from here: https://github.com/adobe/brackets/commits/master/src/nls/root/strings.js when the file is changed to have the same strings as root/strings.js

This comment has been minimized.

@jamesxv7

jamesxv7 Sep 13, 2014

Contributor

Sure, line already reverted.

@jamesxv7

jamesxv7 Sep 13, 2014

Contributor

Sure, line already reverted.

@TomMalbran

This comment has been minimized.

Show comment
Hide comment
@TomMalbran

TomMalbran Sep 13, 2014

Contributor

@jamesxv7 It looks good. I'll merge it after you fix the sha issue. Thanks

Contributor

TomMalbran commented Sep 13, 2014

@jamesxv7 It looks good. I'll merge it after you fix the sha issue. Thanks

@TomMalbran

This comment has been minimized.

Show comment
Hide comment
@TomMalbran

TomMalbran Sep 13, 2014

Contributor

@jamesxv7 Thanks. Merging

Contributor

TomMalbran commented Sep 13, 2014

@jamesxv7 Thanks. Merging

TomMalbran added a commit that referenced this pull request Sep 13, 2014

@TomMalbran TomMalbran merged commit bd219be into adobe:master Sep 13, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@jamesxv7

This comment has been minimized.

Show comment
Hide comment
@jamesxv7

jamesxv7 Sep 13, 2014

Contributor

@peterflynn Thanks a lot for the tip and the correction. I'm currently learning to use the tool (GitHub) and taking more seriously the invested in projects that capture my interest. Brackets is awesome.

Contributor

jamesxv7 commented Sep 13, 2014

@peterflynn Thanks a lot for the tip and the correction. I'm currently learning to use the tool (GitHub) and taking more seriously the invested in projects that capture my interest. Brackets is awesome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment