Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Don't rescan doc for html instrumentation when reattaching to editor #9320

Merged
merged 1 commit into from
Sep 26, 2014

Conversation

redmunds
Copy link
Contributor

This is for #9303

Rescanning doc blows away old ids and replaces them, so synchronization is lost.

This was broken with fix for #7886, so verify that is still fixed.

@JeffryBooher
Copy link
Contributor

I'm seeing this when switching panes:

Uncaught TypeError: Cannot call method 'getSelections' of null HTMLDocument.js:189

This breaks live editing

@JeffryBooher
Copy link
Contributor

  1. Open citrus completed
  2. Split view vertical
  3. Open index.html in right pane (not sure if it matters but that's how i reproduce it)
  4. Start live editing
  5. edit some stuff on the page like you would for smoke tests
  6. click in the left pane (it should be empty)
  7. click in the right pane
    ==> RTE
    the RTE may happen at step 6

@JeffryBooher
Copy link
Contributor

Also I did this a few more times and got this:

Document ref count has fallen below zero! ErrorNotification.js:117
Couldn't find the dom for C:/Users/jsbooher/Documents/GitHub/brackets/test/smokes/citrus completed/index.html ErrorNotification.js:117
Couldn't find the dom for C:/Users/jsbooher/Documents/GitHub/brackets/test/smokes/citrus completed/index.html ErrorNotification.js:117

@redmunds
Copy link
Contributor Author

@JeffryBooher Great catch! This also happens in master, so it doesn't seem to be related to this change. Let's track that in a separate issue.

@redmunds
Copy link
Contributor Author

We should re-test every feature with Split View! :)

@JeffryBooher
Copy link
Contributor

Looks good to me... merging.

JeffryBooher added a commit that referenced this pull request Sep 26, 2014
Don't rescan doc for html instrumentation when reattaching to editor
@JeffryBooher JeffryBooher merged commit 61050fb into master Sep 26, 2014
@JeffryBooher JeffryBooher deleted the randy/issue-9303 branch September 26, 2014 23:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants