This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
For #5852: Clicking an Extension Manager tab while still loading will show it #9594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $(".modal-body", $dlg).scrollTop(models[_activeTabIndex].scrollPos || 0); | ||
| $searchClear.click(); | ||
| $(".modal-body", $dlg).scrollTop((models[_activeTabIndex] && models[_activeTabIndex].scrollPos) || 0); | ||
| clearSearch(); |
There was a problem hiding this comment.
When I tested this, clearsearch() also threw an exception during the call to updateSearchDisabled(). I think this statement needs to be also checked for models[_activeTabIndex] to exist. Maybe you want to wrap both the statements in an if statement
|
@prksingh Changes pushed. |
prksingh
added a commit
that referenced
this pull request
Jan 28, 2015
For #5852: Clicking an Extension Manager tab while still loading will show it
|
@marcelgerber Merged. Thanks for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5852 and #9466.