Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-sheets #105

Closed
auniverseaway opened this issue Apr 13, 2024 · 0 comments · Fixed by #106
Closed

Multi-sheets #105

auniverseaway opened this issue Apr 13, 2024 · 0 comments · Fixed by #106
Assignees
@auniverseaway

Comments

@auniverseaway
Copy link
Member

DA needs to support multi-sheets. This is not only required for complex query indexes, but it's also required for certain milo features.

Criteria of acceptance

  1. Can save multiple sheets in a single JSON file.
  2. Can rename sheets
  3. Fully compatible with Helix
  4. Single sheets fallback to default behavior (to maintain consistency with Helix & existing projects)
  5. Can delete sheets
  6. Reads existing multi-sheets

Not in scope

  1. Re-order sheets
@auniverseaway auniverseaway self-assigned this Apr 13, 2024
auniverseaway added a commit that referenced this issue Apr 13, 2024
@auniverseaway
GH-105 Multi-sheet support
21fda3f 
* Can save multiple sheets in a single JSON file.
* Can rename sheets
* Fully compatible with Helix
* Single sheets fallback to default behavior (to maintain consistency with Helix & existing projects)
* Can delete sheets
* Reads existing multi-sheets

Resolves: #150
auniverseaway added a commit that referenced this issue Apr 13, 2024
@auniverseaway
GH-105 Multi-sheet support
7a0d118 
* Can save multiple sheets in a single JSON file.
* Can rename sheets
* Fully compatible with Helix
* Single sheets fallback to default behavior (to maintain consistency with Helix & existing projects)
* Can delete sheets
* Reads existing multi-sheets

Resolves: #150
@auniverseaway auniverseaway mentioned this issue Apr 13, 2024
Merged
auniverseaway added a commit that referenced this issue Apr 13, 2024
@auniverseaway
GH-105 Multi-sheet support
a560db4 
* Can save multiple sheets in a single JSON file.
* Can rename sheets
* Fully compatible with Helix
* Single sheets fallback to default behavior (to maintain consistency with Helix & existing projects)
* Can delete sheets
* Reads existing multi-sheets

Resolves: #150
auniverseaway added a commit that referenced this issue Apr 13, 2024
@auniverseaway
GH-105 Multi-sheet support
fb0fab6 
* Can save multiple sheets in a single JSON file.
* Can rename sheets
* Fully compatible with Helix
* Single sheets fallback to default behavior (to maintain consistency with Helix & existing projects)
* Can delete sheets
* Reads existing multi-sheets

Resolves: #150
auniverseaway added a commit that referenced this issue Apr 18, 2024
@auniverseaway
GH-105 - Multi-sheet support (#106)
936c59f 
* GH-105 Multi-sheet support

* Can save multiple sheets in a single JSON file.
* Can rename sheets
* Fully compatible with Helix
* Single sheets fallback to default behavior (to maintain consistency with Helix & existing projects)
* Can delete sheets
* Reads existing multi-sheets

Resolves: #150

* Improve tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@auniverseaway auniverseaway

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-105 - Multi-sheet support adobe/da-live
1 participant
@auniverseaway