Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-105 - Multi-sheet support #106

Merged
merged 3 commits into from
Apr 18, 2024
Merged

GH-105 - Multi-sheet support #106

merged 3 commits into from
Apr 18, 2024

Conversation

auniverseaway
Copy link
Member

@auniverseaway auniverseaway commented Apr 13, 2024 •
edited
Loading

Features

  • Can save multiple sheets in a single JSON file.
  • Can rename sheets
  • Fully compatible with Helix
  • Single sheets fallback to default behavior (to maintain consistency with Helix & existing projects)
  • Can delete sheets
  • Reads existing multi-sheets

Bug fixes

  • Hashchange event properly now properly handles changing sheets

Minor

  • Better separation between view and logic for the eventual tests that need to be written.

Out of scope

  • Any existing sheet parsing oddities
  • Saving sheet without previewing to Helix

Resolves: #105

Screenshot 2024-04-13 at 12 37 07 PM

Multi-sheet test URLs

Single-sheet test URLs

Net-new (404) test URLs

Release notes

Features

  • Can save multiple sheets in a single JSON file.
  • Can rename sheets
  • Fully compatible with Helix
  • Single sheets fallback to default behavior (to maintain consistency with Helix & existing projects)
  • Can delete sheets
  • Reads existing multi-sheets
Screenshot 2024-04-13 at 12 37 07 PM

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 13, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Apr 13, 2024 •
edited
Loading

Page Scores Audits Google
/sheet PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/sheet PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/sheet PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@auniverseaway
GH-105 Multi-sheet support
fb0fab6 
* Can save multiple sheets in a single JSON file.
* Can rename sheets
* Fully compatible with Helix
* Single sheets fallback to default behavior (to maintain consistency with Helix & existing projects)
* Can delete sheets
* Reads existing multi-sheets

Resolves: #150
@chrischrischris
Copy link
Contributor

chrischrischris commented Apr 15, 2024 •
edited
Loading

Bug: Pressing Enter in the sheet name field when renaming will delete the sheet

@chrischrischris
Copy link
Contributor

Should we have tab support to move between sheets? Tab goes from edit button to edit button.

@auniverseaway
Copy link
Member Author

Bug: Pressing Enter in the sheet name field when renaming will delete the sheet

@chrischrischris this is fixed.

@auniverseaway
Copy link
Member Author

Should we have tab support to move between sheets? Tab goes from edit button to edit button.

This is also fixed @chrischrischris.

@auniverseaway auniverseaway merged commit 936c59f into main Apr 18, 2024
5 checks passed
@auniverseaway auniverseaway deleted the multish branch April 18, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischrischris chrischrischris chrischrischris approved these changes

@bosschaert bosschaert Awaiting requested review from bosschaert

@karlpauls karlpauls Awaiting requested review from karlpauls

@rgclayton rgclayton Awaiting requested review from rgclayton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multi-sheets
2 participants
@auniverseaway @chrischrischris