Skip to content
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.

Listen to random port if not configured #6

Closed
tripodsan opened this issue Jul 6, 2018 · 1 comment
Closed

Listen to random port if not configured #6

tripodsan opened this issue Jul 6, 2018 · 1 comment
Assignees
@tripodsan
Labels
enhancement New feature or request

Comments

@tripodsan
Copy link
Contributor

tripodsan commented Jul 6, 2018 •
edited
Loading

for local development together with petridish, the git-server should be transparent to the developer. in order to avoid potential conflicts it would be good to start the server on a random port.

suggest

  • if port(s) are configured with 0, the server chooses a random port (which is the default behaviour for server.listen)
  • the returned promise from start() should contain the port information. eg: { port: 1234, portSsl: 1235}
@tripodsan tripodsan added the enhancement New feature or request label Jul 6, 2018
@tripodsan tripodsan mentioned this issue Jul 6, 2018
Closed
@tripodsan tripodsan self-assigned this Jul 11, 2018
tripodsan added a commit that referenced this issue Jul 11, 2018
@tripodsan
Implement random port and gracefull shotdown
0774d14 
Fixes #7, Fixes #6
@tripodsan tripodsan mentioned this issue Jul 11, 2018
Merged
tripodsan added a commit that referenced this issue Jul 12, 2018
@tripodsan
Implement random port and gracefull shotdown (#8)
e3b9b0b 
Fixes #7, Fixes #6
@tripodsan
Copy link
Contributor Author

fixed in v0.0.1-SNAPSHOT.13

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tripodsan tripodsan

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tripodsan