Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

console log output after commit console output with aem up in background #2328

Closed
davidnuescheler opened this issue Mar 13, 2024 · 3 comments · Fixed by #2333
Closed

console log output after commit console output with aem up in background #2328

davidnuescheler opened this issue Mar 13, 2024 · 3 comments · Fixed by #2333
Labels
enhancement New feature or request released

Comments

@davidnuescheler
Copy link
Contributor

i am usually starting dev aem up and attach it to background with ctrl-z & bg or start with aem up &... then i am using the git cli to commit changes and push.

after a commit there is some log output on the console... looks something like this, that is somewhat messing up my typing as it is usually a little bit delayed...

uncled@Davids-MacBook-Pro-4 thinktanked % git commit -m "chore: better checkbox handling"
[rum-slicer 6e88cd7] chore: better checkbox handling
 1 file changed, 1 insertion(+), 1 deletion(-)
uncled@Davids-MacBook-Pro-4 thinktanked % git HEAD or remotes changed, reconfiguring server...
git puUpdated proxy to https://rum-slicer--thinktanked--davidnuescheler.hlx.page
sh origin

as you can see i already started to type git push origin and that got mixed in the git HEAD or remotes changed ... message.

i appreciate that this can happen with the above setup, it is just normally not super intrusive, but in this case it kind of gets me every time...

the simple solution would be to lower the log level on that specific message, but i am not sure if that's desired and i should just change how do things...

@davidnuescheler davidnuescheler added the enhancement New feature or request label Mar 13, 2024
@davidnuescheler
Copy link
Contributor Author

i actually think that the message is not needed altogether... i think if you checkout a new branch the proxy origin has to change but, i don't think this needs to happen with a commit. so maybe we can suppress this message if the origin actually hasn't changed.

@tripodsan
Copy link
Contributor

tripodsan commented Mar 14, 2024

...or you just press ⌘K to reset your terminal and continue with the current line :-)

tripodsan added a commit that referenced this issue Mar 19, 2024
tripodsan pushed a commit that referenced this issue Mar 19, 2024
# [16.3.0](v16.2.14...v16.3.0) (2024-03-19)

### Features

* always proxy from main branch by default ([#2333](#2333)) ([e0b9be2](e0b9be2)), closes [#2331](#2331) [#2328](#2328)
@tripodsan
Copy link
Contributor

🎉 This issue has been resolved in version 16.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants