Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove embedded resource processing (again) #295

Closed
tripodsan opened this issue Oct 30, 2018 · 4 comments · Fixed by #309
Closed

Remove embedded resource processing (again) #295

tripodsan opened this issue Oct 30, 2018 · 4 comments · Fixed by #309
Assignees
Labels
enhancement New feature or request

Comments

@tripodsan
Copy link
Contributor

as discussed with @davidnuescheler the static file processing by parcel has several flaws:

  • referencing the source files from within the htl is counter intuitiv (although referencing them via absolute path, will cause the IDE to complain)
  • parcel doesn't support all possible meta tags/refs and we don't want to be responsible to support them
  • parcel modifies the HTML, e.g. closes tags etc.

Suggestion by @davidnuescheler

  • remove resource processing from the parcel plugin again
  • user needs to copy copy the static files manually to the webroot
@tripodsan tripodsan added the question Further information is requested label Oct 30, 2018
@tripodsan
Copy link
Contributor Author

@trieloff @kptdobe WDYT? the goal is to remove some magic again.

@trieloff
Copy link
Contributor

trieloff commented Nov 1, 2018

Is this about pre-processing the HTL?

@kptdobe
Copy link
Contributor

kptdobe commented Nov 1, 2018

user needs to copy the static files manually to the webroot

I would never do that. I would put them directly in the webroot!

I never liked the /dist folder which contains a version of my source files with a different name and that I have to commit to my repo while it is a generated folder...
When you work with less files, the process is even worst... you have a real/src folder something with your less files, the less build process generates the css files under myhelixproject/src/static and when you run hlx build, those css files get copied again in myhelixproject/dist with a different name. Insane.
If you want a real static resource with a name you control, you need to put it in myhelixproject/dist but that's a risk because you do not know if parcel would delete it at one point.

Definitely +1 for putting all static files under the webroot folder but we need to make sure the IDE knows that / is webroot.

@tripodsan
Copy link
Contributor Author

I would never do that. I would put them directly in the webroot!

that's what I mean :-)

Is this about pre-processing the HTL?

yes. both @davidnuescheler and @kptdobe struggle very much with the treatment of parcel, which often modify the html, don't process all files, etc. I think that we should strive to a what-you-see-is-what-you-get and no-surprises approach ;-)

@tripodsan tripodsan self-assigned this Nov 5, 2018
@tripodsan tripodsan added enhancement New feature or request and removed question Further information is requested labels Nov 8, 2018
@tripodsan tripodsan changed the title Discuss: Remove embedded resource processing (again) Remove embedded resource processing (again) Nov 8, 2018
tripodsan added a commit that referenced this issue Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants