-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unified logging concept cli / petridish / git-server #79
Comments
I'd throw the runtime itself into the mix, too. I think you want to drill-down/filter your logs by:
|
I just realized that each module uses its own instance of winston. so the global logger context would need to be passed around. |
We should have only two places where Winston instances get created:
|
expand logger with a maybe level, which is just like `info`, but gets surpressed when on TTY
Note: Petridish does not allow configurable loggers yet, so this commit only covers the non-petridish logs in hlx up.
we should also look into https://www.npmjs.com/package/bunyan, which has some cool features,
this would allow to pass a child logger to, let's say petridish, which then can be configured differently. |
It would be great to use a standardized logging concept withinh the console apps.
winston supports categories: https://github.com/winstonjs/winston/blob/master/README.md#working-with-multiple-loggers-in-winston and we could use this:
winston.loggers.get()
(eg.winston.loggers.get('git-server')
winston.loggers.has()
) and if not, configures it.helix-winston-config
module for harmonization.The text was updated successfully, but these errors were encountered: