Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Support mounting of documents #97

Closed
tripodsan opened this issue Jul 8, 2020 · 2 comments · Fixed by #119
Closed

Support mounting of documents #97

tripodsan opened this issue Jul 8, 2020 · 2 comments · Fixed by #119
Assignees
@tripodsan
Labels
enhancement New feature or request released

Comments

@tripodsan
Copy link
Contributor

tripodsan commented Jul 8, 2020 •
edited

Is your feature request related to a problem? Please describe.
It would be cool to be able to mount directly a document, eg:

mountpoints:
  /index.md: https://adobe-my.sharepoint.com/personal/tripod_adobe_com/Documents/helix-content/sub/welcome.docx
  /en: https://adobe-my.sharepoint.com/personal/tripod_adobe_com/Documents/helix-content
  /data.json: https://adobe-my.sharepoint.com/personal/tripod_adobe_com/Documents/helix-content/cars.xlsx

this would allow to un-claim the / subtree and have proper fallbacks for other toplevel elements.
it could even be simplified to:

mountpoints:
 /: https://adobe-my.sharepoint.com/personal/tripod_adobe_com/Documents/helix-content/sub/welcome.docx

which would internally be expanded to the /index.md form. this also has the advantage, that a new helix-pages site only needs 1 document to start with, using a document with an arbitrary name (eg. homepage.docx).

/cc @davidnuescheler @trieloff
@tripodsan tripodsan added the enhancement New feature or request label Jul 8, 2020
@trieloff
Copy link
Contributor

trieloff commented Jul 8, 2020

I like this better than all previous ideas we had for fallbacks.

@tripodsan tripodsan mentioned this issue Jul 10, 2020
Closed
@tripodsan tripodsan mentioned this issue Jul 20, 2020
Closed
@tripodsan tripodsan self-assigned this Jul 21, 2020
@tripodsan tripodsan mentioned this issue Jul 21, 2020
Closed
tripodsan added a commit that referenced this issue Jul 21, 2020
@tripodsan
feat(fstab): support mounting of documents
4b9140b 
fixes #97
@tripodsan tripodsan mentioned this issue Jul 21, 2020
Merged
tripodsan added a commit that referenced this issue Jul 21, 2020
@tripodsan
feat(fstab): support mounting of documents (#119)
040bf88 
fixes #97
trieloff pushed a commit that referenced this issue Jul 21, 2020
@semantic-release-bot
chore(release): 1.12.0 [skip ci]
3fcc0b0 
# [1.12.0](v1.11.5...v1.12.0) (2020-07-21)

### Features

* **fstab:** support mounting of documents ([#119](#119)) ([040bf88](040bf88)), closes [#97](#97)
@trieloff
Copy link
Contributor

🎉 This issue has been resolved in version 1.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tripodsan tripodsan

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(fstab): support mounting of documents adobe/helix-content-proxy
2 participants
@trieloff @tripodsan