Skip to content
This repository has been archived by the owner on Feb 28, 2022. It is now read-only.

Support authenticated GitHub access #72

Closed
stevengill opened this issue Oct 12, 2018 · 3 comments · Fixed by #445
Closed

Support authenticated GitHub access #72

stevengill opened this issue Oct 12, 2018 · 3 comments · Fixed by #445
Assignees
@rofe
Labels
enhancement New feature or request released

Comments

@stevengill
Copy link

stevengill commented Oct 12, 2018 •
edited by stefan-guggisberg
Loading

This will be needed eventually for pre-release content and other private code we want to share.

From @trieloff:

  1. https://github.com/adobe/hypermedia-pipeline/blob/master/src/html/fetch-markdown.js needs to be adjusted to make authenticated requests to GitHub using credentials that are provided as parameters.

  2. We need to find a way to pass the parameters. A simple first step would be to just pass them as default params to the action in helix-cli (you would need to create a personal API token in the GitHub UI)

We might also want to eventually support GitCorp repos as well.

This issue covers making Github requests using the provided GITHUB_TOKEN.

Related issues
@trieloff trieloff added the enhancement New feature or request label Oct 15, 2018
@rofe
Copy link
Contributor

rofe commented Aug 9, 2019

Tracked in adobe/helix-cli#912

@rofe rofe closed this as completed Aug 9, 2019
@trieloff
Copy link
Contributor

trieloff commented Aug 9, 2019

There is a cli part to this (passing the token to Fastly or the action) and a pipeline part (using the token in the request). This issue should track the pipeline part.

@trieloff trieloff reopened this Aug 9, 2019
This was referenced Aug 27, 2019
Closed
Closed
Closed
@stefan-guggisberg stefan-guggisberg changed the title Add support for private github repos Support authenticated GitHub access Aug 27, 2019
@stefan-guggisberg stefan-guggisberg self-assigned this Aug 28, 2019
@stefan-guggisberg stefan-guggisberg mentioned this issue Aug 28, 2019
Closed
@rofe rofe assigned rofe and unassigned stefan-guggisberg Aug 28, 2019
rofe added a commit that referenced this issue Aug 28, 2019
@rofe
feat(fetch): support authenticated github access
41ab4a3 
fix #72
@rofe rofe mentioned this issue Aug 28, 2019
Merged
@stefan-guggisberg stefan-guggisberg mentioned this issue Aug 28, 2019
Closed
rofe added a commit that referenced this issue Aug 29, 2019
@rofe
feat(fetch): support authenticated github access
91cbc9b 
fix #72
@rofe rofe closed this as completed in #445 Aug 30, 2019
rofe added a commit that referenced this issue Aug 30, 2019
@rofe
feat(fetch): support authenticated github access (#72) (#445)
2cc1c75 
* feat(fetch): support authenticated github access (#72)
adobe-bot pushed a commit that referenced this issue Aug 30, 2019
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
a127347 
# [5.1.0](v5.0.1...v5.1.0) (2019-08-30)

### Features

* **fetch:** support authenticated github access ([#72](#72)) ([#445](#445)) ([2cc1c75](2cc1c75))
@adobe-bot
Copy link

🎉 This issue has been resolved in version 5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rofe rofe

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(fetch): support authenticated github access (#72) adobe/helix-pipeline
5 participants
@trieloff @stevengill @stefan-guggisberg @rofe @adobe-bot