Skip to content
This repository has been archived by the owner on Feb 25, 2022. It is now read-only.

Implement it #2

Merged
merged 11 commits into from
Aug 19, 2020
Merged

Implement it #2

merged 11 commits into from
Aug 19, 2020

Conversation

trieloff
Copy link
Contributor

No description provided.

@github-actions
Copy link

This PR will trigger a minor release when merged.

@codecov
Copy link

codecov bot commented Aug 19, 2020

Codecov Report

Merging #2 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #2   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            6        38   +32     
=========================================
+ Hits             6        38   +32     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af2734c...f0682e9. Read the comment docs.

@trieloff trieloff requested review from rofe and kptdobe August 19, 2020 14:01
```

- `host`: the inner cdn hostname
- `xfh`: the outer cdn hostnames, comma separated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xfh === X-Forwarded-Host ?

@rofe rofe closed this Aug 19, 2020
@rofe rofe reopened this Aug 19, 2020
Copy link
Contributor

@rofe rofe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! But...

Try https://adobeioruntime.net/api/v1/web/helix/helix-services/purge@ci?host=theblog--adobe.hlx.page&xfh=blog.adobe.com&path=/en/2020/08/14/6-ways-ta-adapt-advance-your-business-during-pandemic.html

... obviously in the case of theblog it's not so simple, because the paths differ between inner and outer CDN... it would be cool if instead of the path parameter, one could alternatively specify a surrogate key. This way we could also use this service to bust all cached index json segments at once.

We could then create a "Purge cache" bookmarklet, similar to the "Preview" one, which calculates the surrogate key from the URL of the source document.

@trieloff trieloff merged commit 27689e5 into main Aug 19, 2020
@trieloff trieloff mentioned this pull request Aug 19, 2020
@trieloff
Copy link
Contributor Author

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants