Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(utils): Add function to calculate surrogate key #125

Merged
merged 1 commit into from
Jun 20, 2019

Conversation

tripodsan
Copy link
Contributor

fixes #123

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #125 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #125      +/-   ##
========================================
+ Coverage      99%    99%   +<.01%     
========================================
  Files          19     19              
  Lines        1507   1513       +6     
  Branches      324    324              
========================================
+ Hits         1492   1498       +6     
  Misses         15     15
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️
src/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6bec7...fc325a2. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #125 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #125      +/-   ##
========================================
+ Coverage      99%    99%   +<.01%     
========================================
  Files          19     19              
  Lines        1507   1513       +6     
  Branches      324    324              
========================================
+ Hits         1492   1498       +6     
  Misses         15     15
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️
src/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6bec7...fc325a2. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #125 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #125      +/-   ##
========================================
+ Coverage      99%    99%   +<.01%     
========================================
  Files          19     19              
  Lines        1507   1513       +6     
  Branches      324    324              
========================================
+ Hits         1492   1498       +6     
  Misses         15     15
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️
src/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f6bec7...d4aae86. Read the comment docs.

@tripodsan tripodsan requested a review from trieloff June 19, 2019 08:54
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 19, 2019

This pull request introduces 1 alert when merging fc325a2 into 7f6bec7 - view on LGTM.com

new alerts:

  • 1 for Hard-coded credentials

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 19, 2019

This pull request introduces 1 alert when merging d4aae86 into 7f6bec7 - view on LGTM.com

new alerts:

  • 1 for Hard-coded credentials

@trieloff trieloff merged commit cd6c2fb into master Jun 20, 2019
@adobe-bot
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tripodsan tripodsan deleted the surrogate-support branch June 20, 2019 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create function to compute surrogate key of a giturl.
3 participants