feat: load sidekick as module into sandbox

adobe · Oct 16, 2021 · 5397039 · 5397039
1 parent 021f56b
commit 5397039
Show file tree

Hide file tree

Showing 5 changed files with 1,629 additions and 59 deletions.
diff --git a/src/extension/background.js b/src/extension/background.js
@@ -37,13 +37,8 @@ function checkTab(id) {
           // enable extension for this tab
           browser.pageAction.show(id);
           browser.tabs.executeScript(id, {
-            runAt: 'document_start',
-            file: './lib/browser-polyfill.min.js',
-          })
-            .then(() => browser.tabs.executeScript(id, {
-              file: './content.js',
-            }))
-            .catch((e) => console.error('failed to inject scripts', e));
+            file: './content.js',
+          });
         } else {
           // disable extension for this tab
           browser.pageAction.hide(id);
@@ -66,7 +61,7 @@ function toggle(id) {
 /**
  * Adds the listeners for the extension.
  */
-function addListeners() {
+(() => {
   // toggle the sidekick when the browser action is clicked
   browser.pageAction.onClicked.addListener(({ id }) => {
     toggle(id);
@@ -125,6 +120,4 @@ function addListeners() {
       }
     });
   });
-}
-
-addListeners();
+})();
diff --git a/src/extension/manifest.json b/src/extension/manifest.json
@@ -18,14 +18,13 @@
   	"page": "background.html"
   },
   "web_accessible_resources": [
-    "app.css",
-    "app.js",
-    "helix.svg",
     "configpicker.js",
+    "lib/browser-polyfill.min.js",
+    "module.js",
     "sidekick.js",
     "utils.js"
   ],
-	"page_action": {
+  "page_action": {
     "default_title": "__MSG_title__",
 		"default_icon": {
 			"16": "icons/helix_logo_16.png",