Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert to Pingdom Standard Http Check #21

Closed
stefan-guggisberg opened this issue Jul 23, 2019 · 1 comment · Fixed by #22
Closed

Revert to Pingdom Standard Http Check #21

stefan-guggisberg opened this issue Jul 23, 2019 · 1 comment · Fixed by #22
Assignees
Labels
enhancement New feature or request released

Comments

@stefan-guggisberg
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The Pingdom Http Custom checks that we’re currently using are IMO useless for Root Cause Analysis & Troubleshouting . Only the Status and the Response Time of the XML response are processed/reported on Pingdom.com. The additional information/context that helix-pingdom-status provides (such as <activation> and <error>) is ignored by Pingdom and doesn’t show up on Get Content. Neither do the received headers. As a consequence you’ll have to manually dig through the activations to find the action response.

Describe the solution you'd like
Reverting back to standard Http check support all information (status code, response body, response headers) is available on Get Content. For simplicity's sake I suggest we keep the current XML response format but return an appropriate Http error status in case of an error (instead of unconditional 200 as mandated by the custom Http checks). Returning a status != 200 will trigger an incident. We'll have to reconfigure the Pingdom checks.

@stefan-guggisberg stefan-guggisberg added the enhancement New feature or request label Jul 23, 2019
@stefan-guggisberg stefan-guggisberg self-assigned this Jul 23, 2019
adobe-bot pushed a commit that referenced this issue Jul 26, 2019
# [3.0.0](v2.0.2...v3.0.0) (2019-07-26)

### Features

* **index:** Return error status code on error (standard Http check) ([1468c04](1468c04)), closes [#21](#21)

### BREAKING CHANGES

* **index:** Returns error Http status on error (Standard Http check) instead of always 200
(Custom Http check)
@adobe-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants