Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow asserts to use Matchers #57

Closed
baubakg opened this issue Jul 18, 2022 · 0 comments · Fixed by #171
Closed

Allow asserts to use Matchers #57

baubakg opened this issue Jul 18, 2022 · 0 comments · Fixed by #171
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.11.0

Comments

@baubakg
Copy link
Member

baubakg commented Jul 18, 2022 •
edited
Loading

It would make assertions easier if the log assertions could work with matchers
AssertLogData.assertLogMatches(String, ParseDefinitionEntry, Matcher)
And
AssertLogData.assertLogMatches(ParseDefinitionEntry, Matcher)
@baubakg baubakg added enhancement New feature or request good first issue Good for newcomers labels Jul 18, 2022
@baubakg baubakg added this to the 1.11.0 milestone Aug 8, 2024
baubakg added a commit that referenced this issue Aug 13, 2024
@baubakg
#57 introduced asserts with matchers
4cb30d6
baubakg added a commit that referenced this issue Aug 29, 2024
@baubakg
#57 decided on the name of the new assertions
96d337b
@baubakg baubakg mentioned this issue Aug 29, 2024
Merged
2 tasks
@baubakg baubakg linked a pull request Aug 29, 2024 that will close this issue
57 allow asserts to use matchers #171
Merged
2 tasks
baubakg added a commit that referenced this issue Aug 29, 2024
@baubakg
Fixed #57 the assertion errors and added unit tests
b9a7b0b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.11.0
Development

Successfully merging a pull request may close this issue.

57 allow asserts to use matchers adobe/log-parser
1 participant
@baubakg