Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix 1423 - add isReadOnly and isDisabled in useRadioGroupState hook #1424

Merged
merged 3 commits into from
Dec 23, 2020
Merged

fix 1423 - add isReadOnly and isDisabled in useRadioGroupState hook #1424

merged 3 commits into from
Dec 23, 2020

Conversation

intergalacticspacehighway
Copy link
Contributor

Closes #1423

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

yarn test radio

🧢 Your Project:

@dannify dannify merged commit ca901fd into adobe:main Dec 23, 2020
@yihuiliao yihuiliao mentioned this pull request Aug 29, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett left review comments

@dannify dannify Awaiting requested review from dannify

@snowystinger snowystinger Awaiting requested review from snowystinger

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add isDisabled and isReadonly attributes in useRadioGroupState hook
3 participants
@intergalacticspacehighway @devongovett @dannify