Internationalization support for Calendar #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an item moved from one section to another, cached nodes and layout infos were not updated properly.
|
Build successful! 🎉 |
dannify
approved these changes
Jul 14, 2021
| year: namedParts.era === 'BC' ? -namedParts.year + 1 : +namedParts.year, | ||
| month: +namedParts.month, | ||
| day: +namedParts.day, | ||
| hour: namedParts.hour === '24' ? 0 : +namedParts.hour, // bugs.chromium.org/p/chromium/issues/detail?id=1045791 |
There was a problem hiding this comment.
I think it came from one of the libraries I ported but I will add it
| @@ -3498,6 +3498,10 @@ describe('ComboBox', function () { | |||
| triggerPress(clearButton); | |||
| }); | |||
|
|
|||
| act(() => { | |||
There was a problem hiding this comment.
I assume it was related to the list layout bugfix
|
Build successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements i18n support for the
CalendarandRangeCalendarcomponents, including support for non-Gregorian calendars used in various countries around the world, and proper support for time zones.I18n for Calendar involves more than just formatting, which is already handled by the
Intl.DateTimeFormatAPI. It also involves determining how many days are in a given month, date arithmetic, and the ability to convert dates between different calendars (i.e. to/from ISO8601 for storage). The JavaScriptDateobject does not support any of this – it operates only in the Gregorian calendar, and also only in the current system time zone. The Temporal proposal currently in TC39 will eventually address these shortcomings in the language, but for now we are on our own. Existing libraries likedate-fnsandmomentdo not handle international dates at all, they are mostly wrappers around the existingDateobject.This PR introduces an
@internationalized/datepackage, which handles i18n date manipulation, including support for multiple calendars, time zones, and general manipulation utilities. It is inspired by thedate-fnsAPI but focused around i18n support. Much of the code is based on the ICU Java library. The objects provided are:Features:
Dateobjects (i.e. absolute time) in a certain time zone, as well as between different calendars.The
Calendarcomponent now also accepts atimeZoneprop to allow the user to control what time zone it is displayed in, as well as the time zone of the dates that are selected by the user. It defaults to the current system time zone.In order to preserve the tree-shakeability, and because not everyone will need support for every calendar,
useCalendarStatenow requires acreateCalendarfunction to be passed which constructs a calendar based on the calendar name retrieved from the current locale. There is a default implementation of this method that includes all calendars and which is passed by React Spectrum, but aria and stately users will need to either use this default or implement it themselves with only the calendars they wish to support.The whole date library is ~5KB min + gzipped, so already a lot smaller than other libraries, but with tree shaking it should be even smaller.
The stories have been updated to add a picker with additional locales that are not generally listed in our storybook. This is because the calendar component varies a lot by region rather than just language. i.e. Arabic in one country may use the Gregorian calendar and the Islamic calendar in another. You can also switch between calendars within any locale, and the preferred calendars for that locale are listed in a separate picker.