On hold - V3 splitview followup #37

snowystinger · 2019-10-30T02:17:34Z

Closes https://jira.corp.adobe.com/browse/RSP-1183, https://jira.corp.adobe.com/browse/RSP-1185, https://jira.corp.adobe.com/browse/RSP-1186, https://jira.corp.adobe.com/browse/RSP-1184, https://jira.corp.adobe.com/browse/RSP-1190, https://jira.corp.adobe.com/browse/RSP-1188, https://jira.corp.adobe.com/browse/RSP-1187
and there seem to be two follow up stories
so this also closes the subtask in the other one https://jira.corp.adobe.com/browse/RSP-1108

✅ Pull Request Checklist:

Included link to corresponding Issue.
Added/updated unit tests and storybook for this change (for new code or code which already has tests).
Filled out test instructions.
Updated documentation (if it already exist for this component).
Looked at the Accessibility Standard and/or talked to @mijordan about Accessibility for this feature.

📝 Test Instructions:

Should match https://www.w3.org/TR/wai-aria-practices-1.1/#windowsplitter
clarified some language in the spec vs what is implemented in v2

Rob Snow 2:22 PM
hey! question on aria specs
https://www.w3.org/TR/wai-aria-practices-1.1/#windowsplitter
this states
The separator element has the aria-valuenow property set to a decimal value representing the current position of the separator.
The separator element has the aria-valuemin property set to a decimal value that represents the position where the primary pane has its minimum size. This is typically 0.
The separator element has the aria-valuemax property set to a decimal value that represents the position where the primary pane has its maximum size . This is typically 100.
how should the values change between collapsible and not?
for instance, if min size is 200 and max is 1000 and we're not collapsible, i'm assuming this for aria
aria min 0 at size 200, aria max 100 at 1000 and valuenow, a percent between the two
for collapsible though, i'm assuming
aria min 0 at size 0? or is 0 still at size 200?

w3.orgw3.org
WAI-ARIA Authoring Practices 1.1
This document provides readers with an understanding of how to use WAI-ARIA 1.1 [WAI-ARIA] to create accessible rich internet applications. It describes considerations that might not be evident to most authors from the WAI-ARIA specification alone and recommends approaches to make widgets, navigation, and behaviors accessible using WAI-ARIA roles, states, and properties. This document is directed primarily to Web application developers, but the guidance is also useful for user agent and assistive technology developers.

James Nurthen 2:24 PM
In this case I think I’d have aria-min as 20 and aria-max as 100
having a min of 0 would give the impression that it can be collapsed to 0
… but realistically the screen reader will probably just read a value as a percentage between the min and the max and not read the actual values of min and max at all
James Nurthen 2:27 PM
so in my example it would read 0% when it gets to the 200 value and 100% at 1000

🧢 Your Team:

RSP

…home button for non-collapsible to make it reflect aria standards Change useDrag1D to be useMoveable and fire off events in 2D Use axis to determine reversals because we may only want to flip over one axis at a time

…ction that is passed the previous state value Write tests for useControlledState to verify all of this Change SplitView to rely more fully on useControlledState Add actions to controlled SplitView stories so that behavior can be confirmed there too

…d to what I thought it would be, will ask about in comments

# Conflicts: # packages/@react-aria/interactions/package.json # packages/@react-aria/interactions/src/index.ts

# Conflicts: # packages/@react-aria/interactions/package.json # packages/@react-aria/splitview/package.json # packages/@react-aria/utils/src/index.ts # packages/@react-spectrum/splitview/package.json # packages/@react-spectrum/splitview/src/SplitView.tsx # packages/@react-stately/splitview/src/useSplitViewState.ts # packages/@react-stately/utils/src/useControlledState.ts # yarn.lock

…into v3-splitview-followup # Conflicts: # packages/@react-aria/i18n/package.json # packages/@react-aria/splitview/package.json # packages/@react-aria/splitview/src/useSplitView.ts # packages/@react-aria/utils/src/index.ts # packages/@react-aria/utils/src/useDrag1D.ts # packages/@react-spectrum/splitview/package.json # packages/@react-spectrum/splitview/test/SplitView.test.js # packages/@react-stately/splitview/package.json # packages/@react-types/shared/src/index.d.ts # packages/@react-types/shared/src/splitview.d.ts

github-actions · 2019-10-30T02:46:22Z

Build successful! View the storybook

LFDanLu · 2019-11-05T00:13:36Z

@snowystinger looks like you got a conflict. Seems pretty straight forward to resolve, gona resolve it locally and keep reviewing

ktabors

When testing in storybook I found a bug in vertical where I click on the adjuster, I try to move down and it jumps up. I try to resize and it is confined to the new size of where it jumped to. Do this a few times, until it is almost at the top and not it jumps down.

What does the scrolling content story do?

ktabors · 2019-11-08T19:19:56Z

packages/@react-aria/i18n/src/context.tsx

@@ -1,3 +1,4 @@
+import {direction} from '@react-types/shared';


add this to the package.json

ktabors · 2019-11-08T19:35:25Z

packages/@react-aria/interactions/src/useMoveable.ts

+// relative position of cursor to a container
+// or as keyboard events
+
+export function useMoveable({containerRef, flipAxis, onHover, onDrag, onPositionChange, onIncrement, onDecrement, onIncrementToMax, onDecrementToMin, onCollapseToggle}: UseMoveableProps): AllHTMLAttributes<HTMLElement> {


Shouldn't you deconstruct the props as below?

# Conflicts: # packages/@react-stately/utils/src/useControlledState.ts

adobe-bot · 2019-11-14T21:00:58Z

Build successful! View the storybook

Merge branch 'master' into v3-splitview-followup # Conflicts: # packages/@react-aria/splitview/package.json # packages/@react-aria/splitview/src/useSplitView.ts # packages/@react-spectrum/splitview/package.json # packages/@react-spectrum/splitview/src/SplitView.tsx # packages/@react-spectrum/splitview/stories/SplitView.stories.js # packages/@react-spectrum/splitview/test/SplitView.test.js # packages/@react-stately/utils/src/useControlledState.ts # packages/@react-stately/utils/test/useControlledState.test.js # packages/@react-types/shared/src/index.d.ts # packages/@react-types/shared/src/splitview.d.ts

adobe-bot · 2020-01-10T23:22:42Z

Build successful! View the storybook

…view-followup # Conflicts: # packages/@react-aria/i18n/src/context.tsx # packages/@react-aria/splitview/package.json # packages/@react-aria/splitview/src/useSplitView.ts # packages/@react-aria/utils/src/getOffset.ts # packages/@react-aria/utils/src/useDrag1D.ts # packages/@react-spectrum/splitview/package.json # packages/@react-stately/splitview/package.json # packages/@react-stately/splitview/src/useSplitViewState.ts # packages/@react-types/shared/src/index.d.ts # packages/@react-types/shared/src/splitview.d.ts

adobe-bot · 2020-05-22T20:22:50Z

Build successful! 🎉

snowystinger · 2020-10-14T00:45:05Z

Closing since useMove work has made a lot of this obsolete. When we work on splitview again, we can look here for some of the remaining work

snowystinger added 17 commits July 31, 2019 15:29

Merge branch 'master' into splitview-followup

f55abb3

Add RTL support

7654ce7

add comment

1ab8e10

add in the focus ring

faf1b0f

move types around, fix linting

31cc3f3

one more lint

75e5910

Add a few more tests because the behavior is a little strange compare…

4c91d18

…d to what I thought it would be, will ask about in comments

Merge branch 'master' into splitview-followup

fb38f2d

remove unused dependency

ef99449

Code review changes!

d2a303b

Merge branch 'master' into splitview-followup

15834b0

# Conflicts: # packages/@react-aria/interactions/package.json # packages/@react-aria/interactions/src/index.ts

fix linter

e0deb1c

Merge branch 'master' into splitview-followup

7493eae

snowystinger requested review from dannify and devongovett as code owners October 30, 2019 02:17

Fix missing deps

63d6e11

ktabors requested changes Nov 8, 2019

View reviewed changes

Merge branch 'master' into v3-splitview-followup

0fffc8a

# Conflicts: # packages/@react-stately/utils/src/useControlledState.ts

dannify changed the title ~~V3 splitview followup~~ On hold - V3 splitview followup Jul 12, 2020

dannify changed the base branch from master to main July 12, 2020 00:53

snowystinger mentioned this pull request Jul 16, 2020

useSlider() and useSliderState() for a Slider component #763

Closed

snowystinger closed this Oct 14, 2020

snowystinger deleted the v3-splitview-followup branch December 6, 2021 23:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

On hold - V3 splitview followup #37

On hold - V3 splitview followup #37

snowystinger commented Oct 30, 2019

github-actions bot commented Oct 30, 2019

LFDanLu commented Nov 5, 2019

ktabors left a comment

ktabors Nov 8, 2019

ktabors Nov 8, 2019

adobe-bot commented Nov 14, 2019

adobe-bot commented Jan 10, 2020

adobe-bot commented May 22, 2020

snowystinger commented Oct 14, 2020

		@@ -1,3 +1,4 @@
		import {direction} from '@react-types/shared';

On hold - V3 splitview followup #37

On hold - V3 splitview followup #37

Conversation

snowystinger commented Oct 30, 2019

✅ Pull Request Checklist:

📝 Test Instructions:

🧢 Your Team:

github-actions bot commented Oct 30, 2019

LFDanLu commented Nov 5, 2019

ktabors left a comment

Choose a reason for hiding this comment

ktabors Nov 8, 2019

Choose a reason for hiding this comment

ktabors Nov 8, 2019

Choose a reason for hiding this comment

adobe-bot commented Nov 14, 2019

adobe-bot commented Jan 10, 2020

adobe-bot commented May 22, 2020

snowystinger commented Oct 14, 2020