Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On hold - V3 splitview followup #37

Closed
wants to merge 21 commits into from
Closed

On hold - V3 splitview followup #37

wants to merge 21 commits into from

Commits on Jul 31, 2019

  1. Change aria-valuenow to accurately reflect aria standards, addressed … 

    …home button for non-collapsible to make it reflect aria standards

Change useDrag1D to be useMoveable and fire off events in 2D
Use axis to determine reversals because we may only want to flip over one axis at a time
    @snowystinger
    snowystinger committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    6dce1d1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into splitview-followup

    @snowystinger
    snowystinger committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    f55abb3 View commit details
    Browse the repository at this point in the history

  3. Add RTL support

    @snowystinger
    snowystinger committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    7654ce7 View commit details
    Browse the repository at this point in the history

  4. add comment

    @snowystinger
    snowystinger committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    1ab8e10 View commit details
    Browse the repository at this point in the history

  5. add in the focus ring

    @snowystinger
    snowystinger committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    faf1b0f View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. move types around, fix linting

    @snowystinger
    snowystinger committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    31cc3f3 View commit details
    Browse the repository at this point in the history

  2. one more lint

    @snowystinger
    snowystinger committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    75e5910 View commit details
    Browse the repository at this point in the history

  3. Allow useControlledState to accept a callback for it's setValue fun… 

    …ction that is passed the previous state value

Write tests for useControlledState to verify all of this
Change SplitView to rely more fully on useControlledState
Add actions to controlled SplitView stories so that behavior can be confirmed there too
    @snowystinger
    snowystinger committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    b4a37b4 View commit details
    Browse the repository at this point in the history

  4. Add a few more tests because the behavior is a little strange compare… 

    …d to what I thought it would be, will ask about in comments
    @snowystinger
    snowystinger committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    4c91d18 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. Merge branch 'master' into splitview-followup

    @snowystinger
    snowystinger committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    fb38f2d View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. remove unused dependency

    @snowystinger
    snowystinger committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    ef99449 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Code review changes!

    @snowystinger
    snowystinger committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    d2a303b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into splitview-followup 

    # Conflicts:
#	packages/@react-aria/interactions/package.json
#	packages/@react-aria/interactions/src/index.ts
    @snowystinger
    snowystinger committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    15834b0 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2019

  1. Merge branch 'master' into splitview-followup 

    # Conflicts:
#	packages/@react-aria/interactions/package.json
#	packages/@react-aria/splitview/package.json
#	packages/@react-aria/utils/src/index.ts
#	packages/@react-spectrum/splitview/package.json
#	packages/@react-spectrum/splitview/src/SplitView.tsx
#	packages/@react-stately/splitview/src/useSplitViewState.ts
#	packages/@react-stately/utils/src/useControlledState.ts
#	yarn.lock
    @snowystinger
    snowystinger committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    b70c569 View commit details
    Browse the repository at this point in the history

  2. fix linter

    @snowystinger
    snowystinger committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    e0deb1c View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2019

  1. Merge branch 'master' into splitview-followup

    @snowystinger
    snowystinger committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    7493eae View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2019

  1. Merge branch 'splitview-followup' of github.com:adobe/react-spectrum … 

    …into v3-splitview-followup

# Conflicts:
#	packages/@react-aria/i18n/package.json
#	packages/@react-aria/splitview/package.json
#	packages/@react-aria/splitview/src/useSplitView.ts
#	packages/@react-aria/utils/src/index.ts
#	packages/@react-aria/utils/src/useDrag1D.ts
#	packages/@react-spectrum/splitview/package.json
#	packages/@react-spectrum/splitview/test/SplitView.test.js
#	packages/@react-stately/splitview/package.json
#	packages/@react-types/shared/src/index.d.ts
#	packages/@react-types/shared/src/splitview.d.ts
    @snowystinger
    snowystinger committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    5a10ab7 View commit details
    Browse the repository at this point in the history

  2. Fix missing deps

    @snowystinger
    snowystinger committed Oct 30, 2019
    Configuration menu
    Copy the full SHA
    63d6e11 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2019

  1. Merge branch 'master' into v3-splitview-followup 

    # Conflicts:
#	packages/@react-stately/utils/src/useControlledState.ts
    @snowystinger
    snowystinger committed Nov 14, 2019
    Configuration menu
    Copy the full SHA
    0fffc8a View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2020

  1. brutal merging 

    Merge branch 'master' into v3-splitview-followup

# Conflicts:
#	packages/@react-aria/splitview/package.json
#	packages/@react-aria/splitview/src/useSplitView.ts
#	packages/@react-spectrum/splitview/package.json
#	packages/@react-spectrum/splitview/src/SplitView.tsx
#	packages/@react-spectrum/splitview/stories/SplitView.stories.js
#	packages/@react-spectrum/splitview/test/SplitView.test.js
#	packages/@react-stately/utils/src/useControlledState.ts
#	packages/@react-stately/utils/test/useControlledState.test.js
#	packages/@react-types/shared/src/index.d.ts
#	packages/@react-types/shared/src/splitview.d.ts
    @snowystinger
    snowystinger committed Jan 10, 2020
    Configuration menu
    Copy the full SHA
    73d39b6 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. Merge commit 'ee7cbcbd355ca27f93c76de29ac0588d9a75b282' into v3-split… 

    …view-followup

# Conflicts:
#	packages/@react-aria/i18n/src/context.tsx
#	packages/@react-aria/splitview/package.json
#	packages/@react-aria/splitview/src/useSplitView.ts
#	packages/@react-aria/utils/src/getOffset.ts
#	packages/@react-aria/utils/src/useDrag1D.ts
#	packages/@react-spectrum/splitview/package.json
#	packages/@react-stately/splitview/package.json
#	packages/@react-stately/splitview/src/useSplitViewState.ts
#	packages/@react-types/shared/src/index.d.ts
#	packages/@react-types/shared/src/splitview.d.ts
    @snowystinger
    snowystinger committed May 22, 2020
    Configuration menu
    Copy the full SHA
    d86781d View commit details
    Browse the repository at this point in the history