Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#3672): WHCM/forced-colors support for column resizer #3818

Merged
merged 4 commits into from
Dec 15, 2022

Conversation

majornista
Copy link
Collaborator

Relates to #3672 , #3368 and #3529

Fix to support @media (forced-colors: active), aka Windows High Contrast Mode, with the Column Resizer, Column Resize Indicator and Nubbin. It doesn’t include comprehensive fixes for other WHCM issues in Table, but at least this feature will not seem broken.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub PR #3672.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Open Table Column Resize examples with Windows High Contrast Mode/forced-colors turned on.
Resize Indicator and Nubbin SVG should render using Highlight as background-color and and HighlightText as color for arrows indicating that the Nubbin can be resized.

🧢 Your Project:

Adobe/Accessibility

Base automatically changed from refactor-column-resizing to main December 13, 2022 22:01
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@devongovett devongovett merged commit 694a181 into main Dec 15, 2022
@devongovett devongovett deleted the pr/3672-whcm branch December 15, 2022 22:21
@snowystinger snowystinger mentioned this pull request Dec 16, 2022
61 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants