Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix width overflow issue in quiet picker #5592

Merged
merged 5 commits into from
Jan 2, 2024

Conversation

pr7prashant
Copy link
Contributor

@pr7prashant pr7prashant commented Dec 18, 2023

Closes #4912

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

  • If you create a picker that is isQuiet and does not have a label, there should not be a large space between the text and the caret.
  • This can be tested in the new added story Picker/Quiet

🧢 Your Project:

Adobe - DX - Campaign

@reidbarber
Copy link
Member

GET_BUILD

@rspbot
Copy link

rspbot commented Dec 18, 2023

@rspbot
Copy link

rspbot commented Dec 18, 2023

## API Changes

unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any', access: 'private' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown top level export { type: 'identifier', name: 'Column' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown type { type: 'link' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }
unknown top level export { type: 'any' }

Copy link
Member

@reidbarber reidbarber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we will need to run chromatic after this change. Also, note to team, let's hold off on merging until after release.

Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran chromatic, looks good

@snowystinger snowystinger merged commit f914372 into adobe:main Jan 2, 2024
26 checks passed
@pr7prashant pr7prashant deleted the issue-4912 branch September 1, 2024 12:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacing is off if a Picker isQuiet and does not have a label
4 participants