Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export LocalizedStringFormatter type in React-Aria #6014

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

alexasselin008
Copy link
Contributor

@alexasselin008 alexasselin008 commented Mar 6, 2024

Closes #6013

I created this PR before the issue was discussed with the maintainers, so feel free to discuss this proposed type export either on this PR or on the related issue.

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

Copy link
Member

@LFDanLu LFDanLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to me, think it might just be something we may have missed exporting when switching from useMessageFormatter to useLocalizedStringFormatter. Thanks!

@reidbarber reidbarber merged commit 9390151 into adobe:main Mar 12, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript build fails due to missing export of LocalizedStringFormatter type in React-Aria
3 participants