-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Virtualizer infinite loop for height 0 #6497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, happy to approve as is as well
## API Changes
unknown top level export { type: 'any' } |
Closes #6298
Alternative to #6357
I believe the issue is that in our layouts, we were calling
isVisible
which checked if the layoutInfo intersects with the visible rect. This always came back as true when the height was 0 because with the display hidden, everything was 0,0. I could fix it inisVisible
, but then we have to remember it for all other layouts. Instead, in Virtualizer, we just don't fetch any layout infos or do any detection if the height is 0. I don't think we'll want to render anything if the height is 0 anyways, so this should be fine.✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: