-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ripple button example docs #6579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
<ExampleCard | ||
url="../Button.html" | ||
title="Button" | ||
description="A ripple helps indicate where an interaction has taken place."> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this description here meant to be this or should it be "A button allows a user to perform an action"? like on the other pages?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ripples are pretty confined to decorative uses, so I opted for this description. I could be convinced otherwise though, that this example should be more focused on the button and the fact it has a ripple is incidental. But then I'd rename all of it and it might be harder to find.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah just to be clear, I'm fine with the current description being present on the cards in the index part of the docs aka this
I just found it bit inconsistent with the other component examples that the component list section had the button labeled with the same description: https://reactspectrum.blob.core.windows.net/reactspectrum/ebaadfce4afacdcbc7b7c4f146c7c377c2128120/docs/react-aria/examples/ripple-button.html#components.
![image](https://private-user-images.githubusercontent.com/9661127/342421773-39b615d7-e620-4463-9547-5e4f1248bb3b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU2Nzk0ODgsIm5iZiI6MTcyNTY3OTE4OCwicGF0aCI6Ii85NjYxMTI3LzM0MjQyMTc3My0zOWI2MTVkNy1lNjIwLTQ0NjMtOTU0Ny01ZTRmMTI0OGJiM2IucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDkwNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA5MDdUMDMxOTQ4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZmUyMWEzNDUxNWY1MzcxYTEzZjU2YjM1M2RkYjhiMmY1YWE3MDUyMTg3YWQyOGIwM2RmMDM4ODcwNjVhN2E1NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.XoxznevTxQ7Qi3kJvrZ6WqBV41QXDRA97_EKmhNlijE)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
o, i totally missed that one, thanks, I'll update
Co-authored-by: Daniel Lu <dl1644@gmail.com>
## API Changes
unknown top level export { type: 'any' } |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: