Ripple button example docs #6579
Conversation
| <ExampleCard | ||
| url="../Button.html" | ||
| title="Button" | ||
| description="A ripple helps indicate where an interaction has taken place."> |
There was a problem hiding this comment.
Was this description here meant to be this or should it be "A button allows a user to perform an action"? like on the other pages?
There was a problem hiding this comment.
Ripples are pretty confined to decorative uses, so I opted for this description. I could be convinced otherwise though, that this example should be more focused on the button and the fact it has a ripple is incidental. But then I'd rename all of it and it might be harder to find.
There was a problem hiding this comment.
Ah just to be clear, I'm fine with the current description being present on the cards in the index part of the docs aka this
I just found it bit inconsistent with the other component examples that the component list section had the button labeled with the same description: https://reactspectrum.blob.core.windows.net/reactspectrum/ebaadfce4afacdcbc7b7c4f146c7c377c2128120/docs/react-aria/examples/ripple-button.html#components.
There was a problem hiding this comment.
o, i totally missed that one, thanks, I'll update
Co-authored-by: Daniel Lu <dl1644@gmail.com>
|
## API Changes
unknown top level export { type: 'any' } |
Closes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project: