Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Menu][Submenu]: Disabled menu item with submenu does not display correct visuals #2176

Closed
najikahalsema opened this issue Sep 18, 2023 · 1 comment · Fixed by #2199
Closed

[Menu][Submenu]: Disabled menu item with submenu does not display correct visuals #2176

najikahalsema opened this issue Sep 18, 2023 · 1 comment · Fixed by #2199
Assignees
@pfulton @castastrophe
Labels
bug Results from a bug in the CSS implementation

Comments

@najikahalsema
Copy link
Collaborator

Description

When a menu item with a submenu is disabled, the chevron should also appear disabled.

Steps to reproduce

  1. Go to Menu storybook
  2. Inspect the submenu element in devtools and set disabled to "true"
  3. Observe that while the text of the menu item is greyed out, the chevron remains "active".

Expected behavior

The chevron should be greyed out, too.

Screenshots

image
CSS storybook example

image
SWC storybook example

Live example on Webcomponents.dev

Environment

Chrome 116.0.5845.187 on Mac OS Ventura 13.5.2

Additional context

Reported by Stefan Puchta of PSWeb
@najikahalsema najikahalsema added the bug Results from a bug in the CSS implementation label Sep 18, 2023
@najikahalsema najikahalsema mentioned this issue Sep 18, 2023
Closed
1 task
@pfulton
Copy link
Collaborator

pfulton commented Sep 20, 2023

Tracking this issue in Jira: https://jira.corp.adobe.com/browse/CSS-594

jawinn added a commit that referenced this issue Oct 3, 2023
@jawinn
fix(menu): drill-in disabled menu item chevron
d7a5fc6 
A drill-in set to "open" was no longer showing the disabled color for
the chevron icon. Moves disabled CSS after other CSS, which resolves
this issue.

Also includes this in the existing Storybook example for drill-in.

Fixes #2176
@jawinn jawinn mentioned this issue Oct 3, 2023
Merged
13 tasks
pfulton pushed a commit that referenced this issue Oct 13, 2023
@jawinn @pfulton
fix(menu): drill-in disabled menu item chevron
d015a16 
A drill-in set to "open" was no longer showing the disabled color for
the chevron icon. Moves disabled CSS after other CSS, which resolves
this issue.

Also includes this in the existing Storybook example for drill-in.

Fixes #2176
pfulton pushed a commit that referenced this issue Oct 13, 2023
@jawinn
fix(menu): drill-in disabled menu item chevron (#2199)
2dba5d9 
A drill-in set to "open" was no longer showing the disabled color for
the chevron icon. Moves disabled CSS after other CSS, which resolves
this issue.

Also includes this in the existing Storybook example for drill-in.

Fixes #2176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfulton pfulton

@castastrophe castastrophe

Labels
bug Results from a bug in the CSS implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(menu): drill-in disabled menu item chevron adobe/spectrum-css
3 participants
@pfulton @castastrophe @najikahalsema