Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: RSP V3 Dialog #710

Merged
merged 18 commits into from
Jul 28, 2020
Merged

feat: RSP V3 Dialog #710

merged 18 commits into from
Jul 28, 2020

Conversation

GarthDB
Copy link
Member

@GarthDB GarthDB commented Apr 29, 2020 •
edited
Loading

Description

Syncing up with React Spectrum V3 work on Dialog.

It has some breaking stuff by using grid and such, but it also breaks our examples.

How and where has this been tested?

  • How this was tested:
  • Browser(s) and OS(s) this was tested with:

Screenshots

image

To-do list

  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • This pull request is ready to merge.

@GarthDB GarthDB changed the title WIP: React V3 Dialog WIP: React V3 Dialog [do not merge] Apr 29, 2020
@lazd lazd marked this pull request as draft April 29, 2020 17:44
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/abd7738-result-2020-04-29_17-46-33/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/abd7738-result-2020-04-29_17-46-33/dist/docs/

@lazd lazd changed the title WIP: React V3 Dialog [do not merge] feat: RSP V3 Dialog Apr 29, 2020
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/1bbaafb-result-2020-04-29_22-41-48/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/1bbaafb-result-2020-04-29_22-41-48/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/66a0cea-result-2020-04-29_23-07-13/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/66a0cea-result-2020-04-29_23-07-13/dist/docs/

@GarthDB GarthDB mentioned this pull request May 18, 2020
Closed
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/081fcc5-result-2020-05-21_18-20-49/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/081fcc5-result-2020-05-21_18-20-49/dist/docs/

@GarthDB GarthDB marked this pull request as ready for review May 27, 2020 08:14
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/c3600a1-result-2020-05-27_08-24-23/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/c3600a1-result-2020-05-27_08-24-23/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/5728822-result-2020-05-27_09-12-19/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/5728822-result-2020-05-27_09-12-19/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/03153c4-result-2020-05-27_17-47-28/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/03153c4-result-2020-05-27_17-47-28/dist/docs/

@GarthDB GarthDB mentioned this pull request May 27, 2020
Merged
4 tasks
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/0ffd297-result-2020-05-27_18-36-24/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/0ffd297-result-2020-05-27_18-36-24/dist/docs/

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/0dbe3ba-result-2020-05-27_22-13-44/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/0dbe3ba-result-2020-05-27_22-13-44/dist/docs/

@GarthDB GarthDB requested a review from jianliao May 27, 2020 23:11
bernhard-adobe
bernhard-adobe reviewed May 30, 2020
View reviewed changes
Copy link
Contributor

@bernhard-adobe bernhard-adobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe some screenshots would be nice.
@jianliao do we have an option for Backstop.js to run the page in Mobile viewport?

components/dialog/index.css Outdated Show resolved Hide resolved
components/dialog/index.css Show resolved Hide resolved
components/dialog/index.css Show resolved Hide resolved
components/dialog/index.css Outdated Show resolved Hide resolved
components/popover/index.css Show resolved Hide resolved
@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/4ffd173-result-2020-06-16_21-08-06/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/4ffd173-result-2020-06-16_21-08-06/dist/docs/

jianliao
jianliao approved these changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@jianliao jianliao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing all the dialog examples.

@adobe-spectrum-bot
Copy link
Collaborator

Test result: http://opensource.adobe.com/spectrum-css-vr-results/027a79c-result-2020-06-16_23-11-00/html_report/

Dev Site: http://opensource.adobe.com/spectrum-css-vr-results/027a79c-result-2020-06-16_23-11-00/dist/docs/

@snowystinger
Copy link
Member

Why do so many of the dialogs show up with deprecated?

@GarthDB GarthDB changed the base branch from master to main July 21, 2020 17:18
@adobe-spectrum-bot
Copy link
Collaborator

Spectrum CSS documentation build successfully! 🎉

View the documentation

@adobe-spectrum-bot
Copy link
Collaborator

VRT successfully! 🎊

View the VRT result

@GarthDB GarthDB merged commit 33d6638 into main Jul 28, 2020
@GarthDB GarthDB deleted the dialog-rsp-v3 branch July 28, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianliao jianliao jianliao approved these changes

@bernhard-adobe bernhard-adobe bernhard-adobe approved these changes

@lazd lazd Awaiting requested review from lazd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@GarthDB @adobe-spectrum-bot @snowystinger @lazd @jianliao @bernhard-adobe @devongovett