fix(textfield): textarea-issue-3432 #3452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tachometer resultsChromenumber-field permalink
search permalink
slider permalink
textfield permalink
Firefoxnumber-field permalink
search permalink
slider permalink
textfield permalink
|
|
@blunteshwar Can you adjust your markdown readme properly. We want to maintain a good PR hygiene always. Thanks |
|
Hopefully when you catch up to While you're in this file. Would you mind taking a little time to investigate whether the Core Tokens updates unlocked allowing the |
1 task
sure |
|
@blunteshwar Many VRT's are failing. Can you please check. |
done! |
Nope, the textarea with "quite" is not growing, its behaving the same way it was behaving before |
Westbrook
force-pushed
the
bug/textarea-3432
branch
from
fb115be
to
85088fe
Compare
TarunAdobe
added a commit
that referenced
this pull request
Jul 19, 2023
* fix(meter): added role meter progressbar in meter component (#3459) Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com> * docs: updated swatch mixed documentations (#3455) Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com> * fix(textfield): update focus state when [multiline][quiet] (#3452) * fix: menu item missing aria labels (#3417) * testing * fix(menu): menu-item with submenu lacks aria-haspopup and aria-expanded * fix(menu): added aria-expanded and aria-haspopup to menu-item * fix(menu): fixed the aria-controls attribute of menu-item * fix(menu): reviewed changes * fix(menu): reviewed changes-2 * fix(menu): removed the comment * fix(menu): removed white space * fix(menu): white space removed * chore: bump @web/test-runner from 0.16.1 to 0.17.0 Bumps [@web/test-runner](https://github.com/modernweb-dev/web/tree/HEAD/packages/test-runner) from 0.16.1 to 0.17.0. - [Release notes](https://github.com/modernweb-dev/web/releases) - [Changelog](https://github.com/modernweb-dev/web/blob/master/packages/test-runner/CHANGELOG.md) - [Commits](https://github.com/modernweb-dev/web/commits/@web/test-runner@0.17.0/packages/test-runner) --- updated-dependencies: - dependency-name: "@web/test-runner" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore: bump webpack-bundle-analyzer from 4.8.0 to 4.9.0 Bumps [webpack-bundle-analyzer](https://github.com/webpack-contrib/webpack-bundle-analyzer) from 4.8.0 to 4.9.0. - [Release notes](https://github.com/webpack-contrib/webpack-bundle-analyzer/releases) - [Changelog](https://github.com/webpack-contrib/webpack-bundle-analyzer/blob/master/CHANGELOG.md) - [Commits](webpack-contrib/webpack-bundle-analyzer@v4.8.0...v4.9.0) --- updated-dependencies: - dependency-name: webpack-bundle-analyzer dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore: bump netlify-cli from 12.12.0 to 15.9.0 Bumps [netlify-cli](https://github.com/netlify/cli) from 12.12.0 to 15.9.0. - [Release notes](https://github.com/netlify/cli/releases) - [Changelog](https://github.com/netlify/cli/blob/main/CHANGELOG.md) - [Commits](netlify/cli@v12.12.0...v15.9.0) --- updated-dependencies: - dependency-name: netlify-cli dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * chore: bump husky from 8.0.2 to 8.0.3 Bumps [husky](https://github.com/typicode/husky) from 8.0.2 to 8.0.3. - [Release notes](https://github.com/typicode/husky/releases) - [Commits](typicode/husky@v8.0.2...v8.0.3) --- updated-dependencies: - dependency-name: husky dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * chore: bump word-wrap from 1.2.3 to 1.2.4 Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * chore: bump @types/react from 18.0.25 to 18.2.15 Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.0.25 to 18.2.15. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Rajdeep Chandra <rajdeep.chandra@bsil.com> Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com> Co-authored-by: Piyush Vashisht <pvashish@adobe.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #3432
I changed some conditions in textfield.css file so that while styling "grows" and "quite" property does not interfere/
Related issue(s)
Motivation and context
Now the textarea with properties "grows" and "quite" is properly functioning when focused.
How has this been tested?
using dev tools
Screenshots (if appropriate)
Screen.Recording.2023-07-14.at.2.03.54.PM.mov
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.