chore: use lit@3.0 #3209

Westbrook · 2023-05-17T22:03:06Z

Description

Lit@3.0 is coming. It's focus is on removing support for out-of-date browsers, and cleaning up deprecations internal to their APIs, with the intent of including the smallest possible breaking changes.

This clarifies any breaking/required changes for the library to get updated to it.

How has this been tested?

Test case 1
1. All tests pass
Test case 2
1. Storybook/the docs site are usable

Types of changes

Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
If my change required a change to the documentation, I have updated the documentation in this pull request.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

github-actions · 2023-05-17T22:07:15Z

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

github-actions · 2023-05-17T23:24:09Z

Tachometer results

Chrome

accordion permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	420 kB	131.03ms - 133.25ms	-	faster ✔ 4% - 7% 6.19ms - 9.55ms
branch	402 kB	138.75ms - 141.27ms	slower ❌ 5% - 7% 6.19ms - 9.55ms	-

action-bar permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	489 kB	68.85ms - 72.48ms	-	unsure 🔍 -3% - +2% -2.25ms - +1.75ms
branch	470 kB	70.08ms - 71.76ms	unsure 🔍 -2% - +3% -1.75ms - +2.25ms	-

action-button permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	521 kB	99.41ms - 101.03ms	-	faster ✔ 3% - 6% 2.66ms - 6.04ms
branch	501 kB	103.09ms - 106.06ms	slower ❌ 3% - 6% 2.66ms - 6.04ms	-

action-group permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	543 kB	64.94ms - 66.33ms	-	faster ✔ 3% - 6% 2.27ms - 4.25ms
branch	522 kB	68.19ms - 69.60ms	slower ❌ 3% - 7% 2.27ms - 4.25ms	-

action-menu permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	655 kB	161.47ms - 164.74ms	-	faster ✔ 3% - 6% 4.31ms - 9.76ms
branch	631 kB	167.96ms - 172.32ms	slower ❌ 3% - 6% 4.31ms - 9.76ms	-

alert-dialog permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	460 kB	96.23ms - 97.34ms	-	faster ✔ 1% - 5% 1.45ms - 4.66ms
branch	443 kB	98.33ms - 101.35ms	slower ❌ 1% - 5% 1.45ms - 4.66ms	-

asset permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	364 kB	12.19ms - 12.29ms	-	unsure 🔍 -1% - +1% -0.08ms - +0.07ms
branch	348 kB	12.20ms - 12.30ms	unsure 🔍 -1% - +1% -0.07ms - +0.08ms	-

avatar permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	402 kB	24.20ms - 24.59ms	-	unsure 🔍 -2% - +1% -0.39ms - +0.16ms
branch	384 kB	24.32ms - 24.70ms	unsure 🔍 -1% - +2% -0.16ms - +0.39ms	-

badge permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	401 kB	32.08ms - 32.55ms	-	unsure 🔍 -2% - +0% -0.54ms - +0.03ms
branch	385 kB	32.40ms - 32.74ms	unsure 🔍 -0% - +2% -0.03ms - +0.54ms	-

banner permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	362 kB	20.72ms - 20.87ms	-	faster ✔ 0% - 1% 0.03ms - 0.26ms
branch	347 kB	20.86ms - 21.02ms	slower ❌ 0% - 1% 0.03ms - 0.26ms	-

button-group permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	447 kB	58.90ms - 61.31ms	-	faster ✔ 1% - 5% 0.57ms - 3.27ms
branch	430 kB	61.42ms - 62.65ms	slower ❌ 1% - 6% 0.57ms - 3.27ms	-

button permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	453 kB	68.50ms - 69.97ms	-	faster ✔ 4% - 7% 3.01ms - 5.16ms
branch	436 kB	72.53ms - 74.10ms	slower ❌ 4% - 7% 3.01ms - 5.16ms	-

card permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	510 kB	58.32ms - 58.87ms	-	faster ✔ 2% - 4% 1.09ms - 2.23ms
branch	489 kB	59.76ms - 60.75ms	slower ❌ 2% - 4% 1.09ms - 2.23ms	-

checkbox permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	421 kB	70.81ms - 71.83ms	-	unsure 🔍 -2% - +0% -1.39ms - +0.23ms
branch	402 kB	71.27ms - 72.54ms	unsure 🔍 -0% - +2% -0.23ms - +1.39ms	-

coachmark permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	626 kB	145.59ms - 148.10ms	-	faster ✔ 1% - 3% 1.84ms - 5.04ms
branch	611 kB	149.29ms - 151.27ms	slower ❌ 1% - 3% 1.84ms - 5.04ms	-

color-area permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	457 kB	129.52ms - 130.92ms	-	faster ✔ 0% - 2% 0.38ms - 1.98ms
branch	439 kB	131.01ms - 131.78ms	slower ❌ 0% - 2% 0.38ms - 1.98ms	-

Firefox

accordion permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	420 kB	263.98ms - 274.02ms	-	faster ✔ 2% - 7% 4.40ms - 19.40ms
branch	402 kB	275.33ms - 286.47ms	slower ❌ 2% - 7% 4.40ms - 19.40ms	-

action-bar permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	489 kB	146.64ms - 153.00ms	-	unsure 🔍 -4% - +2% -5.82ms - +2.54ms
branch	470 kB	148.75ms - 154.17ms	unsure 🔍 -2% - +4% -2.54ms - +5.82ms	-

action-button permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	521 kB	222.97ms - 232.63ms	-	unsure 🔍 -6% - +1% -13.21ms - +3.09ms
branch	501 kB	226.29ms - 239.43ms	unsure 🔍 -1% - +6% -3.09ms - +13.21ms	-

action-group permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	543 kB	162.79ms - 169.73ms	-	unsure 🔍 -2% - +4% -3.27ms - +5.87ms
branch	522 kB	161.99ms - 167.93ms	unsure 🔍 -4% - +2% -5.87ms - +3.27ms	-

action-menu permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	655 kB	316.96ms - 328.56ms	-	faster ✔ 1% - 5% 1.86ms - 15.66ms
branch	631 kB	327.78ms - 335.26ms	slower ❌ 1% - 5% 1.86ms - 15.66ms	-

alert-dialog permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	460 kB	205.35ms - 212.01ms	-	unsure 🔍 -4% - +0% -8.13ms - +0.49ms
branch	443 kB	209.76ms - 215.24ms	unsure 🔍 -0% - +4% -0.49ms - +8.13ms	-

asset permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	364 kB	28.95ms - 31.61ms	-	unsure 🔍 -3% - +10% -0.87ms - +2.83ms
branch	348 kB	28.02ms - 30.58ms	unsure 🔍 -9% - +3% -2.83ms - +0.87ms	-

avatar permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	402 kB	53.78ms - 58.10ms	-	unsure 🔍 -8% - +5% -4.32ms - +2.92ms
branch	384 kB	53.74ms - 59.54ms	unsure 🔍 -5% - +8% -2.92ms - +4.32ms	-

badge permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	401 kB	72.63ms - 77.01ms	-	unsure 🔍 -6% - +4% -4.36ms - +2.84ms
branch	385 kB	72.72ms - 78.44ms	unsure 🔍 -4% - +6% -2.84ms - +4.36ms	-

banner permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	362 kB	40.81ms - 44.67ms	-	unsure 🔍 -5% - +8% -2.00ms - +3.20ms
branch	347 kB	40.39ms - 43.89ms	unsure 🔍 -7% - +5% -3.20ms - +2.00ms	-

button-group permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	447 kB	137.45ms - 145.43ms	-	unsure 🔍 -7% - +0% -10.67ms - +0.35ms
branch	430 kB	142.80ms - 150.40ms	unsure 🔍 -0% - +8% -0.35ms - +10.67ms	-

button permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	453 kB	154.89ms - 162.63ms	-	unsure 🔍 -6% - +1% -10.56ms - +2.36ms
branch	436 kB	157.69ms - 168.03ms	unsure 🔍 -2% - +7% -2.36ms - +10.56ms	-

card permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	510 kB	105.04ms - 111.48ms	-	unsure 🔍 -5% - +3% -5.92ms - +3.00ms
branch	489 kB	106.63ms - 112.81ms	unsure 🔍 -3% - +5% -3.00ms - +5.92ms	-

checkbox permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	421 kB	164.75ms - 171.81ms	-	unsure 🔍 -4% - +2% -7.31ms - +4.19ms
branch	402 kB	165.30ms - 174.38ms	unsure 🔍 -3% - +4% -4.19ms - +7.31ms	-

coachmark permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	626 kB	407.67ms - 419.37ms	-	unsure 🔍 -2% - +2% -7.52ms - +7.68ms
branch	611 kB	408.60ms - 418.28ms	unsure 🔍 -2% - +2% -7.68ms - +7.52ms	-

color-area permalink

Version	Bytes	Avg Time	vs remote	vs branch
npm latest	457 kB	223.01ms - 231.91ms	-	unsure 🔍 -3% - +3% -6.30ms - +7.42ms
branch	439 kB	221.68ms - 232.12ms	unsure 🔍 -3% - +3% -7.42ms - +6.30ms	-

github-actions · 2024-02-13T20:39:50Z

Lighthouse scores

Category	Latest (report)	Main (report)	Branch (report)
Performance	0.95	0.98	0.98
Accessibility	1	1	1
Best Practices	1	1	1
SEO	1	0.92	0.92
PWA	1	1	1

What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category	Latest	Main	Branch
Total	228.851 kB	217.401 kB	211.579 kB 🏆
Scripts	60.408 kB	54.567 kB	48.649 kB 🏆
Stylesheet	35.846 kB	30.893 kB 🏆	31.004 kB
Document	5.885 kB	5.199 kB 🏆	5.214 kB
Third Party	126.712 kB	126.742 kB	126.712 kB

Request Count

Category	Latest	Main	Branch
Total	43	43	43
Scripts	35	35	35
Stylesheet	5	5	5
Document	1	1	1
Third Party	2	2	2

Westbrook force-pushed the lit-3 branch from 67153dd to dd2ff45 Compare May 17, 2023 22:05

Westbrook force-pushed the lit-3 branch from dd2ff45 to a573747 Compare May 17, 2023 22:14

Westbrook force-pushed the lit-3 branch from a573747 to bb7834f Compare May 24, 2023 11:36

Westbrook force-pushed the lit-3 branch from bb7834f to bd092f9 Compare July 13, 2023 23:09

Westbrook force-pushed the lit-3 branch from bd092f9 to 780d850 Compare September 29, 2023 21:39

Westbrook force-pushed the lit-3 branch 7 times, most recently from e06bc93 to 6d7c732 Compare October 30, 2023 21:02

Westbrook mentioned this pull request Oct 31, 2023

chore: bump @lit-labs/virtualizer from 2.0.7 to 2.0.9 #3756

Closed

Westbrook force-pushed the lit-3 branch 8 times, most recently from cb67bcc to 8593789 Compare November 6, 2023 13:31

This was referenced Nov 6, 2023

Update lit to v3 #3773

Closed

refactor: prepare for lit@3.0 usage #3776

Merged

This was referenced Nov 28, 2023

chore: bump @lit-labs/virtualizer from 2.0.7 to 2.0.11 #3829

Closed

chore: bump @lit-labs/observers from 2.0.0 to 2.0.2 #3833

Closed

Westbrook force-pushed the lit-3 branch from 8593789 to ad48095 Compare December 11, 2023 17:21

Westbrook force-pushed the lit-3 branch from ad48095 to 84caa9b Compare December 21, 2023 19:29

Westbrook force-pushed the lit-3 branch from 84caa9b to aa5f431 Compare January 3, 2024 00:20

Westbrook force-pushed the lit-3 branch from aa5f431 to bf7e45b Compare January 4, 2024 15:36

Westbrook mentioned this pull request Jan 16, 2024

chore: bump lit-html from 2.8.0 to 3.1.1 #3945

Closed

Westbrook force-pushed the lit-3 branch from bf7e45b to f31ed7f Compare January 17, 2024 15:37

Westbrook force-pushed the lit-3 branch from f31ed7f to 9bf5939 Compare January 30, 2024 17:07

Westbrook force-pushed the lit-3 branch 3 times, most recently from a40d7c9 to 959e6f0 Compare February 8, 2024 12:50

Westbrook force-pushed the lit-3 branch from 959e6f0 to ebe9b2f Compare February 13, 2024 20:34

Westbrook force-pushed the lit-3 branch 2 times, most recently from 4096f28 to 681bb8d Compare February 20, 2024 21:27

Westbrook force-pushed the lit-3 branch 10 times, most recently from 6a5d05a to 9a4ec9a Compare March 3, 2024 18:27

Westbrook force-pushed the lit-3 branch from 9a4ec9a to 2bbc2ba Compare March 11, 2024 13:01

Westbrook force-pushed the lit-3 branch 2 times, most recently from 8485e76 to 65df063 Compare March 20, 2024 12:48

chore: use lit@3.0

69aa9ec

Westbrook force-pushed the lit-3 branch from 65df063 to 69aa9ec Compare March 20, 2024 12:58

Westbrook closed this Mar 20, 2024

chore: use lit@3.0 #3209

chore: use lit@3.0 #3209

Conversation

Westbrook commented May 17, 2023

Description

How has this been tested?

Types of changes

Checklist

github-actions bot commented May 17, 2023 • edited

Branch preview

github-actions bot commented May 17, 2023 • edited

Tachometer results

accordion permalink

action-bar permalink

action-button permalink

action-group permalink

action-menu permalink

alert-dialog permalink

asset permalink

avatar permalink

badge permalink

banner permalink

button-group permalink

button permalink

card permalink

checkbox permalink

coachmark permalink

color-area permalink

accordion permalink

action-bar permalink

action-button permalink

action-group permalink

action-menu permalink

alert-dialog permalink

asset permalink

avatar permalink

badge permalink

banner permalink

button-group permalink

button permalink

card permalink

checkbox permalink

coachmark permalink

color-area permalink

github-actions bot commented Feb 13, 2024 • edited

Lighthouse scores

Transfer Size

Request Count

github-actions bot commented May 17, 2023 •

edited

github-actions bot commented May 17, 2023 •

edited

github-actions bot commented Feb 13, 2024 •

edited