refactor: prepare for lit@3.0 usage #3776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
requested review from
Rajdeepc,
blunteshwar,
najikahalsema and
TarunAdobe
Tachometer resultsChromeaccordion permalink
action-bar permalink
action-button permalink
action-group permalink
action-menu permalink
alert-dialog permalink
asset permalink
avatar permalink
badge permalink
banner permalink
button-group permalink
button permalink
card permalink
checkbox permalink
coachmark permalink
color-area permalink
color-handle permalink
color-loupe permalink
color-slider permalink
color-wheel permalink
dialog permalink
divider permalink
dropzone permalink
field-group permalink
field-label permalink
grid permalink
help-text permalink
icon permalink
icons permalink
illustrated-message permalink
infield-button permalink
link permalink
menu permalink
meter permalink
number-field permalink
overlay permalink
picker-button permalink
picker permalink
popover permalink
progress-bar permalink
progress-circle permalink
quick-actions permalink
radio permalink
search permalink
sidenav permalink
slider permalink
split-button permalink
split-view permalink
swatch permalink
switch permalink
table permalink
tabs permalink
tags permalink
textfield permalink
thumbnail permalink
toast permalink
tooltip permalink
top-nav permalink
tray permalink
underlay permalink
Firefoxaccordion permalink
action-bar permalink
action-button permalink
action-group permalink
action-menu permalink
alert-dialog permalink
asset permalink
avatar permalink
badge permalink
banner permalink
button-group permalink
button permalink
card permalink
checkbox permalink
coachmark permalink
color-area permalink
color-handle permalink
color-loupe permalink
color-slider permalink
color-wheel permalink
dialog permalink
divider permalink
dropzone permalink
field-group permalink
field-label permalink
grid permalink
help-text permalink
icon permalink
icons permalink
illustrated-message permalink
infield-button permalink
link permalink
menu permalink
meter permalink
number-field permalink
overlay permalink
picker-button permalink
picker permalink
popover permalink
progress-bar permalink
progress-circle permalink
quick-actions permalink
radio permalink
search permalink
sidenav permalink
slider permalink
split-button permalink
split-view permalink
swatch permalink
switch permalink
table permalink
tabs permalink
tags permalink
textfield permalink
thumbnail permalink
toast permalink
tooltip permalink
top-nav permalink
tray permalink
underlay permalink
|
Westbrook
force-pushed
the
pre-lit-3
branch
2 times, most recently
from
27a39b7
to
0123302
Compare
Westbrook
force-pushed
the
pre-lit-3
branch
5 times, most recently
from
6e19a9e
to
50d5acb
Compare
Westbrook
force-pushed
the
pre-lit-3
branch
2 times, most recently
from
e0d83c1
to
d8be6b9
Compare
This was referenced Nov 28, 2023
najikahalsema
approved these changes
Nov 30, 2023
packages/overlay/test/index.ts
Outdated
There was a problem hiding this comment.
Is this just an opportunistic testing refactor, or would it be affected by a 3.0 upgrade? (Beyond the render time being faster, which is why i'm assuming we wouldn't need so many nextFrame()s here?)
There was a problem hiding this comment.
On the lest we assume that close will happen, but without confirming open first it was having trouble passing.
Comment on lines
+397
to
+400
| await nextFrame(); | ||
| await nextFrame(); | ||
| await nextFrame(); | ||
| await nextFrame(); |
There was a problem hiding this comment.
Why all the nextFrames here?
There was a problem hiding this comment.
This is working to ensure that all child elements have el.updateComplete'ed. We would likely benefit from an advanced version of fixture or other helper that ensured whole tree of elements has updated before running tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fast forward changes needed to be compliant with
lit@3.0so that consumers could choose to force that dependency as needed. This also opens the door for an interstitial step wherein we depend on^2 || ^3if needed by consuming projects for a period of time.Related issue(s)
How has this been tested?
Types of changes
Checklist