-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(base): move lit imports to base #4416
Conversation
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
tools/base/src/index.ts
Outdated
@@ -13,3 +13,4 @@ governing permissions and limitations under the License. | |||
export * from './Base.js'; | |||
export * from './sizedMixin.js'; | |||
export * from 'lit'; | |||
export * from 'lit/async-directive.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to see this in the repro!
Please move this to a async-directive.ts
file that mirrors directive.ts
so that tree shaking is less required to exclude this code from a project.
Then I think we're good to ship this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Tachometer resultsChromeaccordion permalinkbasic-test
action-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-dialog permalinkbasic-test
asset permalinkbasic-test
avatar permalinktest-basic
badge permalinkbasic-test
banner permalinktest-basic
button-group permalinkbasic-test
button permalinktest-basic
card permalinktest-basic
checkbox permalinktest-basic
coachmark permalinkbasic-test
color-area permalinkbasic-test
color-field permalinkbasic-test
color-handle permalinkbasic-test
color-loupe permalinkbasic-test
color-slider permalinkbasic-test
color-wheel permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
dialog permalinkbasic-test
divider permalinkbasic-test
dropzone permalinktest-basic
field-group permalinkbasic-test
field-label permalinkbasic-test
grid permalinkbasic-test
help-text permalinkbasic-test
icon permalinktest-basic
icons permalinktest-basic
illustrated-message permalinktest-basic
infield-button permalinkbasic-test
link permalinktest-basic
menu permalinktest-basic
meter permalinkbasic-test
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-bar permalinkbasic-test
progress-circle permalinkbasic-test
quick-actions permalinkbasic-test
radio permalinktest-basic
search permalinktest-basic
sidenav permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
split-view permalinkbasic-test
swatch permalinkbasic-test
switch permalinktest-basic
table permalinkbasic-test
tabs permalinkbasic-test
tags permalinkbasic-test
textfield permalinktest-basic
thumbnail permalinkbasic-test
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
top-nav permalinkbasic-test
tray permalinkbasic-test
truncated permalinkbasic-test
underlay permalinkbasic-test
Firefoxaccordion permalinkbasic-test
action-bar permalinkbasic-test
action-button permalinkbasic-test
action-group permalinkbasic-test
action-menu permalinktest-basic
test-directive permalink
test-lazy permalink
test-open-close-directive permalink
test-open-close permalink
alert-dialog permalinkbasic-test
asset permalinkbasic-test
avatar permalinktest-basic
badge permalinkbasic-test
banner permalinktest-basic
button-group permalinkbasic-test
button permalinktest-basic
card permalinktest-basic
checkbox permalinktest-basic
coachmark permalinkbasic-test
color-area permalinkbasic-test
color-field permalinkbasic-test
color-handle permalinkbasic-test
color-loupe permalinkbasic-test
color-slider permalinkbasic-test
color-wheel permalinkbasic-test
combobox permalinkbasic-test
light-dom-test permalink
dialog permalinkbasic-test
divider permalinkbasic-test
dropzone permalinktest-basic
field-group permalinkbasic-test
field-label permalinkbasic-test
grid permalinkbasic-test
help-text permalinkbasic-test
icon permalinktest-basic
icons permalinktest-basic
illustrated-message permalinktest-basic
infield-button permalinkbasic-test
link permalinktest-basic
menu permalinktest-basic
meter permalinkbasic-test
number-field permalinkbasic-test
overlay permalinkbasic-test
directive-test permalink
element-test permalink
lazy-test permalink
picker-button permalinkbasic-test
picker permalinkbasic-test
popover permalinktest-basic
progress-bar permalinkbasic-test
progress-circle permalinkbasic-test
quick-actions permalinkbasic-test
radio permalinktest-basic
search permalinktest-basic
sidenav permalinktest-basic
slider permalinktest-basic
split-button permalinkbasic-test
split-view permalinkbasic-test
swatch permalinkbasic-test
switch permalinktest-basic
table permalinkbasic-test
tabs permalinkbasic-test
tags permalinkbasic-test
textfield permalinktest-basic
thumbnail permalinkbasic-test
toast permalinktest-basic
tooltip permalinktest-basic
test-directive permalink
test-element permalink
test-lazy permalink
top-nav permalinkbasic-test
tray permalinkbasic-test
truncated permalinkbasic-test
underlay permalinkbasic-test
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not fully clear that the CI fails for this, but can you run yarn
with you changes and then commit the updates, then we'll be good to merge this.
Apologies if I've said similar before (or if I end up needing to say similar again). 😬 👍🏼
4a1f3cb
to
02e35e2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. I'll catch this branch up to main
and if we're still green
02e35e2
to
a20f6a4
Compare
Fixing issue with various lit imports introduced in 0.42.3 release.
Description
Both Checkbox and Overlay included imports directly from lit while neither package has lit as a direct dependency. Moving these imports to pull from base as this seems to be the established standard.
Related issue(s)
Motivation and context
Unable to install the latest release without needing to add additional dependencies.
How has this been tested?
Successfully builds
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main
.