removing proxy config option and editing proxy demo to reflect changes

adobe · Feb 13, 2023 · 35e3f73 · 35e3f73
1 parent 4f4d13c
commit 35e3f73
Show file tree

Hide file tree

Showing 13 changed files with 1,014 additions and 253 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -27,8 +27,5 @@
     "lerna": "^4.0.0",
     "prettier": "^2.7.1",
     "pretty-quick": "^3.1.3"
-  },
-  "dependencies": {
-    "undici": "^5.18.0"
   }
 }
diff --git a/packages/target-decisioning-engine/src/artifactProvider.js b/packages/target-decisioning-engine/src/artifactProvider.js
@@ -91,7 +91,6 @@ function ArtifactProvider(config, telemetryProvider) {
 
   const fetchWithRetry = getFetchWithRetry(
     fetchApi,
-    config.proxyAgent,
     NUM_FETCH_RETRIES,
     errorMessage => Messages.ERROR_MAX_RETRY(NUM_FETCH_RETRIES, errorMessage),
     error => eventEmitter(ARTIFACT_DOWNLOAD_FAILED, { artifactLocation, error })

diff --git a/packages/target-decisioning-engine/src/geoProvider.js b/packages/target-decisioning-engine/src/geoProvider.js
@@ -126,13 +126,9 @@ export function GeoProvider(config, artifact) {
         headers[HTTP_HEADER_FORWARDED_FOR] = geoRequestContext.ipAddress;
       }
 
-      const options = { headers };
-
-      if (config.proxyAgent != null) {
-        options.dispatcher = config.proxyAgent;
-      }
-
-      return fetchApi(geoLookupPath, options)
+      return fetchApi(geoLookupPath, {
+        headers
+      })
         .then(geoResponse =>
           geoResponse
             .json()

diff --git a/packages/target-decisioning-engine/types/DecisioningConfig.d.ts b/packages/target-decisioning-engine/types/DecisioningConfig.d.ts
@@ -1,6 +1,5 @@
 import { DecisioningArtifact } from "./DecisioningArtifact";
 import { ParseDomainFunc } from "./DecisioningContext";
-import { ProxyAgent } from "undici";
 
 export interface DecisioningConfig {
   /**
@@ -87,9 +86,4 @@ export interface DecisioningConfig {
    * Function used to parse domains
    */
   parseDomainImpl?: ParseDomainFunc;
-
-  /**
-   * Proxy Agent to specify a proxy for the fetch implementation
-   */
-  proxyAgent: ProxyAgent;
 }