Skip to content
This repository has been archived by the owner on Jun 16, 2018. It is now read-only.

Commit

Permalink
Add a note about hostname completion not working well with --cc compl…
Browse files Browse the repository at this point in the history
…etion

Reviewed by Simon Hausmann.

Hostname completion tries to resolve anything after an @ sign which is present
in the completed list of contributor emails to CC.

* Scripts/webkit-tools-completion.sh:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  • Loading branch information
jocelyn.turcotte@nokia.com committed Jun 26, 2012
1 parent 438996f commit 535d672
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
11 changes: 11 additions & 0 deletions Tools/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
2012-06-25 Jocelyn Turcotte <turcotte.j@gmail.com>

Add a note about hostname completion not working well with --cc completion

Reviewed by Simon Hausmann.

Hostname completion tries to resolve anything after an @ sign which is present
in the completed list of contributor emails to CC.

* Scripts/webkit-tools-completion.sh:

2012-06-26 Sheriff Bot <webkit.review.bot@gmail.com>

Unreviewed, rolling out r121244.
Expand Down
1 change: 1 addition & 0 deletions Tools/Scripts/webkit-tools-completion.sh
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ __webkit-patch_generate_reply()

__webkit-patch_upload_cc_generate_reply()
{
# Note: This won't work well if hostname completion is enabled, disable it with: shopt -u hostcomplete
# Completion is done on tokens and our comma-separated list is one single token, so we have to do completion on the whole list each time.
# Return a \n separated list for each possible bugzilla email completion of the substring following the last comma.
# Redirect strerr to /dev/null to prevent noise in the shell if this ever breaks somehow.
Expand Down

0 comments on commit 535d672

Please sign in to comment.